← Back to issue list

tests: run the CLA check in a docker container.

View original Github issue

Metadata

Project
snapcraft
Number
#1191
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged in #1191 via f95ab03fd: the CLA check now runs in Docker, making test execution uniform and Store-trigger customization easier.

Resolution: closed resolved

Reason: PR #1191 was merged as commit f95ab03fd. The change moved the CLA check into a Docker container to standardize tests and simplify customization of the Store trigger.

Evaluated by: mr-cal-bot

No scores available.

Issue body

We were doing the CLA check out of the docker container to save a few minutes, but it's affecting the trigger from the store. With this change, all the tests are uniform and the store trigger can be customized more easily. LP: [#1672788](https://bugs.launchpad.net/snapcraft/+bug/1672788)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in #1191 via f95ab03fd: the CLA check now runs in Docker, making test execution uniform and Store-trigger customization easier.
stealth/space-bunny-alpha — closed resolved Merged PR #1191 (f95ab03fd) runs the CLA check in Docker, standardizing tests and simplifying customization of the Store trigger.
qwen/qwen3.6-35b-a3b — — Merged changes to execute the CLA check within a Docker container, standardizing the test environment and simplifying store trigger configuration. The update modifies a single file with minimal line changes.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Moved the CLA check inside a Docker container to resolve store trigger issues caused by running it externally. This change standardizes test execution and simplifies store trigger customization, addressing LP #1672788.

Update history

No update history recorded yet.

Related work

Related issues

No related issues found above the similarity threshold.