← Back to issue list

cleanbuild: packaging independent detection.

View original Github issue

Metadata

Project
snapcraft
Number
#1199
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged changes making LXD detection packaging-independent for snap and manual installs. Detection logic moved from lifecycle to the lxd module, eliminating the translation layer. Approved, passed CI, and merged across four files.

Suggested action:

No scores available.

Issue body

Don't use the repo to detect if lxd is available as this will prevent use when lxd is provided as a snap or manually installed. It also makes the logic packaging , agnosting, meaning that a translation layer to figure out what provides the `lxc` command is not necessary. The work here also migrates the detection out of the lifecycle and into the lxd module. LP: #1666735 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes making LXD detection packaging-independent for snap and manual installs. Detection logic moved from lifecycle to the lxd module, eliminating the translation layer. Approved, passed CI, and merged across four files.
qwen3.6-35b-a3b-mtp-q6 Merged. Refactored LXD detection to be packaging-agnostic by removing repository dependency and moving logic from lifecycle to the lxd module, enabling support for snap and manual installations.
qwen3.6-35b-a3b-mtp-q6 Merged. Refactored LXD detection to be packaging-agnostic by removing repository dependency, enabling snap and manual installations. Detection logic migrated from the lifecycle module to the lxd module, resolving LP #1666735.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1639641 Don't assume lxd from dpkg snapcraft (launchpad) closed Resolved via merged pull request #904, updating snapcraft cleanbuild to detect LXD installed via snap rather than only checking dpkg.
72%
#434 fix(i/lxd): make lxd download inspector more strict fetch-service merged Merged a fix making the LXD download inspector format verification stricter to prevent snap assertion download rejections. Approved by two reviewers, passed CI checks, and modified six files with 79 additions and 12 deletions.
72%
#2621 build providers: support injection for LXD snapcraft merged Merged after approval and passing CI. Implements LXD injection support via snapd's new file API, removes legacy mounts, and refactors code for better separation of concerns across 12 files.
72%
#3112 spread: remove dead code for lxd setup and add debug prints snapcraft merged Merged removal of redundant elif dead code in LXD setup logic and addition of debug prints for LXD snap install failures. Approved by one reviewer, passed CI checks, and integrated.
71%
#1655 lxd: distinguish argless clean from clean -s pull snapcraft merged Merged fix for bug 1727445 distinguishing argless snapcraft clean from snapcraft clean -s pull in LXD. Approved by one reviewer, passed CI, and verified via manual testing. Changes span three files with a minimal diff.
71%
#1364 lxd: Inject snapcraft and core snaps into the container snapcraft merged Merged. Injects the host's snapcraft and core snaps into LXD containers to ensure build version consistency. Approved by one reviewer, modifying nine files with 360 additions and 46 deletions.
71%