← Back to issue list

cli: improve push output.

View original Github issue

Metadata

Project
snapcraft
Number
#1240
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged #1240 via commit 0d7468013, improving push output with file basenames, removing duplicate messages and a trailing spinner, and renaming Upload to Push.

Resolution: closed resolved

Reason: PR #1240 was approved and merged as commit 0d7468013, implementing the output and terminology improvements described in the change.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Use basename of file to leave space for the widget (useful when pushing a delta). Don't print the 'Upload' message twice and don't leave a trailing spinner after the release is complete. Upload renamed to push to be more consistent. LP: #1625784 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #1240 via commit 0d7468013, improving push output with file basenames, removing duplicate messages and a trailing spinner, and renaming Upload to Push.
stealth/space-bunny-alpha — closed resolved Merged PR #1240 (commit 0d7468013, 'cli: improve push output.') made push print the file basename to leave room for the delta widget, removed the duplicate 'Upload' message and trailing spinner, and renamed 'Upload' to 'push' for consistency (LP: #1625784).
stealth/space-bunny-alpha — closed resolved Merged PR #1240 improved push output by using basenames for widget spacing, removing duplicate and trailing spinner output, and renaming Upload to Push. Commit 0d7468013.
qwen/qwen3.6-35b-a3b — — Merged. Improves CLI push output by using file basenames for widget spacing, fixing duplicate messages, removing trailing spinners, and renaming upload to push. Approved by one reviewer with a +15/-12 diff across four files.
qwen3.6-35b-a3b-mtp-q6 — — Merged CLI push output improvements. Updates use file basenames for widget spacing, remove duplicate upload messages, fix trailing spinner behavior, and rename upload to push for consistency. Resolves LP: #1625784.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1804439 Push output needs love snapcraft (launchpad) closed Push output cleanup landed in snapcraft PR #2469 (commit 194589f0e): duplicate/full-path messages and the "cached source snap" line dropped to debug, filenames made consistent and shortened.
71%