sources: validate unknown source-type in yaml
Metadata
Current evaluation
Closed without merging due to unresolved review comments and a failing CLA check caused by an email mismatch. The proposed validation for unknown source types in snapcraft.yaml was abandoned.
Suggested action: —
No scores available.
Issue body
Invalid source-type defaults to Local source (handler) and it doesn't print an error message
LP: [#1650943](https://bugs.launchpad.net/snapcraft/+bug/1650943)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging due to unresolved review comments and a failing CLA check caused by an email mismatch. The proposed validation for unknown source types in snapcraft.yaml was abandoned. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without merging. The contribution aimed to validate unknown YAML source-types and raise a KeyError. Reviewers requested direct dictionary indexing. It was abandoned due to a failing CLA check from an email mismatch, with no further activity. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Validate unknown source-types in YAML by raising an error instead of defaulting to Local. Reviewers requested KeyError handling and default fixes. The pull request was closed without merging due to a failing CLA check from an email mismatch. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1297 sources: validate unknown source-type in yaml | snapcraft | merged | Merged. Validates unknown source types in snapcraft.yaml using an enum. Updates the handler dictionary to raise a KeyError on invalid input instead of silently defaulting to Local. Approved by reviewer, passed CI, and achieved 100% diff coverage. | |
| #1650943 Wrong source-type in yaml is ignored | snapcraft (launchpad) | closed | Closed without a documented fix or PR. Invalid source-type values in snapcraft.yaml remain silently ignored, suggesting the bug was abandoned or resolved upstream without tracking. | |
| #1524663 Issues while validating snapcraft.yaml: None is not of type 'string' | snapcraft (launchpad) | closed | Closed without resolution. The report detailed snapcraft.yaml validation errors involving null plugins and file patterns. With zero comments and over a decade of inactivity, the issue was abandoned. |