← Back to issue list

Added support for 'branches' in Store responses (release, close, and status).

View original Github issue

Metadata

Project
snapcraft
Number
#1280
Type
pull request
State
merged
Author
facundobatista
Labels
Created
Updated
Closed

Current evaluation

Merged into master. Adds branch support to Store responses for release, close, and status. Improves error handling for unknown branches, removes unused code, and cleans up tests. Approved, passed CI, and achieved 100% diff coverage.

Suggested action:

No scores available.

Issue body

While doing this, I also changed the behaviour for the case of not understanding some branch info that could come from the server: now, instead of exploding, it just logs in error and present that channel empty (this will ease future evolutions that may be needed; for example, currently these commands would explode when working on a package with branches!). Also, I removed the "_tabulated_status" function, as wasn't used. Finally, removed several FakeTerminal instantiaton in a lot of tests that the only thing they do was to shadow the same thing from their base class. LP: [#1686162](https://bugs.launchpad.net/snapcraft/+bug/1686162)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into master. Adds branch support to Store responses for release, close, and status. Improves error handling for unknown branches, removes unused code, and cleans up tests. Approved, passed CI, and achieved 100% diff coverage.
qwen3.6-35b-a3b-mtp-q6 Merged. Adds branch support to Store release, close, and status responses. Improves error handling for unknown branches, removes unused code, and cleans up tests. Changes were merged after minor terminology feedback.
qwen3.6-35b-a3b-mtp-q6 Merged into master, adding branch support to Store release, close, and status responses. Unknown branch data now logs errors instead of crashing. Removed unused code and cleaned tests. Achieved 100% diff coverage. Minor terminology feedback noted.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1686162 Support "branch"es in Store responses snapcraft (launchpad) closed Feature request to properly display branch channels in Store release, status, and close responses was closed without implementation. Zero comments and no linked pull requests indicate the request was abandoned.
74%
#3892 store: support close for an on prem store snapcraft merged Merged into main after approval and passing CI. Adds close support for on-prem stores, modifying four files and increasing test coverage by 0.02%.
70%