Added support for 'branches' in Store responses (release, close, and status).
Metadata
Current evaluation
Merged #1280 as commit 9a2b6a7da, adding branch support to Store release, close, and status responses and safely handling unknown branch data.
Resolution: closed resolved
Reason: Approved PR #1280 was merged into master as commit 9a2b6a7da. It added Store branch handling and changed unknown branch responses from crashes to logged errors with an empty channel.
Evaluated by: mr-cal-bot
No scores available.
Issue body
While doing this, I also changed the behaviour for the case of not understanding some branch info that could come from the server: now, instead of exploding, it just logs in error and present that channel empty (this will ease future evolutions that may be needed; for example, currently these commands would explode when working on a package with branches!).
Also, I removed the "_tabulated_status" function, as wasn't used.
Finally, removed several FakeTerminal instantiaton in a lot of tests that the only thing they do was to shadow the same thing from their base class.
LP: [#1686162](https://bugs.launchpad.net/snapcraft/+bug/1686162)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #1280 as commit 9a2b6a7da, adding branch support to Store release, close, and status responses and safely handling unknown branch data. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1280 (9a2b6a7da) added branch support to Store release, close, and status responses, logging errors instead of crashing on unknown branch data. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1280 added branch support to Store release, close, and status responses; unknown branch data now logs an error instead of crashing. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #1280 in 9a2b6a7da, adding branch support to Store release, close, and status responses and gracefully handling unknown branch data. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. Adds branch support to Store responses for release, close, and status. Improves error handling for unknown branches, removes unused code, and cleans up tests. Approved, passed CI, and achieved 100% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Adds branch support to Store release, close, and status responses. Improves error handling for unknown branches, removes unused code, and cleans up tests. Changes were merged after minor terminology feedback. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1686162 Support "branch"es in Store responses | snapcraft (launchpad) | closed | Store support for branch channels in release, close, and status responses was merged in snapcore/snapcraft#1280 via commit 9a2b6a7da. |