← Back to issue list

autotools: don't force uniqueness on configflags

View original Github issue

Metadata

Project
snapcraft
Number
#1337
Type
pull request
State
merged
Author
Saviq
Labels
—
Created
Updated
Closed

Current evaluation

PR #1337 by Saviq merged as commit 714425a34, dropping uniqueItems from autotools configflags in the schema so repeated flags (e.g. multiple -skip) are allowed. Resolves LP bug #1694707; 2 files, +1/-4 lines.

Resolution: closed resolved

Reason: The PR itself was merged into snapcraft as commit 714425a34 after two approvals (the only comment, from come-maiz, was a request for a second +1). It implements the fix for LP bug #1694707 by removing the forced uniqueness constraint on autotools configflags.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: [#1694707](https://bugs.launchpad.net/snapcraft/+bug/1694707)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #1337 by Saviq merged as commit 714425a34, dropping uniqueItems from autotools configflags in the schema so repeated flags (e.g. multiple -skip) are allowed. Resolves LP bug #1694707; 2 files, +1/-4 lines.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#1337 (commit 714425a34), removing forced uniqueness of autotools configflags and allowing repeated arguments such as -skip.
qwen/qwen3.6-35b-a3b — — Merged to stop forcing uniqueness on autotools configflags, resolving Launchpad bug #1694707. Approved by two reviewers, the change modifies two files with a net reduction of three lines.
qwen3.6-35b-a3b-mtp-q6 — — Merged after review. Changes to the autotools build system remove forced uniqueness on configflags, resolving Launchpad bug #1694707.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#3066 (confidence 62%)

    Later renamed autotools configflags to autotools-configure-parameters in the v2 plugin (commit 75dd96faa), migrating away from the option this PR adjusted.

  • Related To: snapcraft#1338 (confidence 30%)

    Adjacent autotools/go plugin work merged in the same period; not a resolution of this change.

Related issues

Issue Project State Summary Similarity
#1694707 autotools.configflags enforces uniqueness snapcraft (launchpad) closed Resolved by snapcore/snapcraft PR #1337 (commit 714425a34), which removed the uniqueness restriction from autotools configflags.
76%