← Back to issue list

git: don't use --remote for updating submodules

View original Github issue

Metadata

Project
snapcraft
Number
#1344
Type
pull request
State
merged
Author
Saviq
Labels
—
Created
Updated
Closed

Current evaluation

Merged #1344 as commit a8500f718, removing --remote from Git submodule updates so the commit recorded in the superproject is checked out.

Resolution: closed resolved

Reason: PR #1344 was approved and merged, resolving Launchpad bug #1694765. Commit a8500f718 stopped passing --remote when updating submodules, preserving the superproject's pinned commit.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Remote in updating submodules means the tip of the remote branch is checked out, not the commit recorded in the superproject. This means the project loses control over what content is actually checked out. LP: [#1694765](https://bugs.launchpad.net/snapcraft/+bug/1694765)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #1344 as commit a8500f718, removing --remote from Git submodule updates so the commit recorded in the superproject is checked out.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#1344; commit a8500f718 stopped passing --remote when updating submodules, ensuring the superproject’s recorded commit is checked out.
qwen/qwen3.6-35b-a3b — — Merged. Removes the --remote flag from submodule updates, which incorrectly checked out the remote branch tip instead of the superproject's recorded commit. Approved by reviewer, passed CI, and merged to restore deterministic version control.
qwen3.6-35b-a3b-mtp-q6 — — Merged removal of the --remote flag from submodule updates. Using --remote checked out remote branch tips instead of superproject-recorded commits, causing loss of version control. The change ensures submodule updates strictly follow recorded commits.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1694765 source-type: git uses --remote for submodules snapcraft (launchpad) closed Fixed by merged PR snapcore/snapcraft#1344 (commit a8500f718), removing --remote from Git submodule updates so superproject-recorded revisions are honored.
76%