← Back to issue list

cmake plugin: call the cmake using build dir as source

View original Github issue

Metadata

Project
snapcraft
Number
#1414
Type
pull request
State
closed
Author
come-maiz
Labels
Created
Updated
Closed

Current evaluation

Closed without merging. The author abandoned the changes after review feedback noted cmake natively supports out-of-source builds, making the proposed in-source approach unnecessary. The linked bug remains open.

Suggested action:

No scores available.

Issue body

LP: [#1704933](https://bugs.launchpad.net/snapcraft/+bug/1704933)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Closed without merging. The author abandoned the changes after review feedback noted cmake natively supports out-of-source builds, making the proposed in-source approach unnecessary. The linked bug remains open.
qwen3.6-35b-a3b-mtp-q6 Maintainers debated out-of-source versus in-source builds, leading the author to close and abandon the pull request. The linked bug remains open for future tracking.
qwen3.6-35b-a3b-mtp-q6 Closed without merging. @kyrofa rejected the change, noting CMake natively supports out-of-source builds, making the proposed copy unnecessary. The author closed the PR, leaving the linked bug open.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1704933 cmake plugin: difficult to patch src using scriptlets snapcraft (launchpad) closed Closed without resolution. The cmake plugin incorrectly passes the source directory to cmake, preventing build-dir patching. The issue was abandoned, likely superseded by newer plugin architecture.
74%
#1825797 cmake: Shouldn't use sourcedir for building snapcraft (launchpad) open Request for cmake plugin to use out-of-source builds (build in SNAPCRAFT_PART_BUILD instead of SNAPCRAFT_PART_SRC). 2689 days old, no labels, no comments, no maintainer interaction. The current craft-parts cmake plugin already implements out-of-source builds via get_out_of_source_build() returning True.
72%
#1599572 qmake plugin uses out-of-source build snapcraft (launchpad) closed Abandoned. The qmake plugin out-of-source build failure was closed without resolution or code changes.
71%