← Back to issue list

kbuild plugin: move over the cross-compiling logic from the kernel plugin

View original Github issue

Metadata

Project
snapcraft
Number
#1417
Type
pull request
State
merged
Author
kalikiana
Labels
Created
Updated
Closed

Current evaluation

Merged the refactoring moving cross-compiling logic from the kernel to kbuild plugin. Approved by two reviewers and passed CI. A reviewer noted future enhancements for u-boot and dragonboard support, but core changes were successfully integrated.

Suggested action:

No scores available.

Issue body

Move the cross-compiling bits from the kernel plugin to the kbuild plugin, taking advantage of the fact that kbuild's being used as a superclass. Note: The test doesn't include x86 32 or 64bit because snapcraft doesn't support it (see _options.py).

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged the refactoring moving cross-compiling logic from the kernel to kbuild plugin. Approved by two reviewers and passed CI. A reviewer noted future enhancements for u-boot and dragonboard support, but core changes were successfully integrated.
qwen3.6-35b-a3b-mtp-q6 Merged cross-compiling logic from the kernel plugin into the kbuild plugin, leveraging kbuild as a superclass. Reviewers suggested future u-boot and ARCH override enhancements, but the change was accepted and merged as-is.
qwen3.6-35b-a3b-mtp-q6 Merged cross-compiling logic from the kernel plugin into the kbuild plugin. Reviewers noted missing u-boot install and ARCH overrides, but the core refactoring was accepted and merged as-is.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2368 {kbuild,kernel} plugin: add support for bases snapcraft merged Merged after review and CI approval, adding core16 and core18 base support to the KBuild and Kernel plugins. Resolved Launchpad bugs #1794790 and #1794791 across 7 files with 100% diff coverage.
70%
#378 New plugin: kbuild snapcraft merged Merged a new kbuild plugin adding 481 lines across 7 files. Reviewers approved after clarifying prepend/append logic for make oldconfig compatibility and multiple kdefconfig support for Ubuntu kernel builds.
70%