← Back to issue list

kbuild plugin: move over the cross-compiling logic from the kernel plugin

View original Github issue

Metadata

Project
snapcraft
Number
#1417
Type
pull request
State
merged
Author
kalikiana
Labels
—
Created
Updated
Closed

Current evaluation

Merged into main as commit ea3670dc5 via #1417, moving cross-compilation logic from the kernel plugin into the kbuild superclass; U-Boot install and ARCH overrides were excluded.

Resolution: closed resolved

Reason: The approved PR was merged as commit ea3670dc5, implementing the requested kbuild cross-compilation changes. Later PR #1432 addressed the comment's missing install-target support, but no ARCH override was added here.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Move the cross-compiling bits from the kernel plugin to the kbuild plugin, taking advantage of the fact that kbuild's being used as a superclass. Note: The test doesn't include x86 32 or 64bit because snapcraft doesn't support it (see _options.py).

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged into main as commit ea3670dc5 via #1417, moving cross-compilation logic from the kernel plugin into the kbuild superclass; U-Boot install and ARCH overrides were excluded.
stealth/space-bunny-alpha — closed resolved Merged PR #1417 as commit ea3670dc5, moving cross-compilation logic from the kernel plugin into kbuild. U-Boot install and ARCH override support remained outside the change.
qwen/qwen3.6-35b-a3b — — Merged the refactoring moving cross-compiling logic from the kernel to kbuild plugin. Approved by two reviewers and passed CI. A reviewer noted future enhancements for u-boot and dragonboard support, but core changes were successfully integrated.
qwen3.6-35b-a3b-mtp-q6 — — Merged cross-compiling logic from the kernel plugin into the kbuild plugin, leveraging kbuild as a superclass. Reviewers suggested future u-boot and ARCH override enhancements, but the change was accepted and merged as-is.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#1432 (confidence 98%)

    Later PR #1432 added support for Makefiles without an install target, addressing one U-Boot concern raised in the comment.

Related issues

No related issues found above the similarity threshold.