← Back to issue list

nodejs plugin: copy the content of out of tree symlinks

View original Github issue

Metadata

Project
snapcraft
Number
#1418
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1418 (commit b1154631d) fixed the Node.js plugin to copy content from out-of-tree symlinks, resolving the Heroku link-farm problem in LP #1702661.

Resolution: closed resolved

Reason: The approved PR was merged as commit b1154631d, updating the Node.js plugin to copy out-of-tree symlink content and address LP #1702661.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: [#1702661](https://bugs.launchpad.net/snapcraft/+bug/1702661) Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1418 (commit b1154631d) fixed the Node.js plugin to copy content from out-of-tree symlinks, resolving the Heroku link-farm problem in LP #1702661.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#1418 (commit b1154631d), fixing the nodejs plugin to copy out-of-tree symlink contents and address the Heroku link-farm failure in LP #1702661.
qwen/qwen3.6-35b-a3b — — Merged fix for the nodejs plugin to copy out-of-tree symlink contents, resolving LP #1702661 and a heroku build link farm issue. Approved by one reviewer, passed CI, and modified two files with 69 additions and 7 deletions.
qwen3.6-35b-a3b-mtp-q6 — — Merged nodejs plugin update to copy out-of-tree symlink contents, resolving a heroku build link farm issue from mixed local and remote modules. Integrated into the archive rebuild job.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: snapcraft (launchpad)#1702661 (confidence 100%)

    Underlying Launchpad bug reporting Heroku build failures caused by the link-farm issue.

Related issues

Issue Project State Summary Similarity
#1702661 node plugin fails to capture symlink snapcraft (launchpad) closed Fixed by canonical/snapcraft#1418 (commit b1154631d): the Node.js plugin copied out-of-tree symlink targets during staging, resolving the Heroku CLI packaging failure.
75%