← Back to issue list

lxd: pass original CLI arguments down to container

View original Github issue

Metadata

Project
snapcraft
Number
#1498
Type
pull request
State
closed
Author
kalikiana
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged in favor of #1493, which forwarded --target-arch only when explicitly set; commit 0a7de4515 preserved the container architecture default.

Resolution: closed superseded

Reason: Maintainers chose the alternative implementation in #1493. Commit 0a7de4515 forwarded --target-arch only when explicitly specified instead of passing all original CLI arguments.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Originally trying to fix the --target-arch default as [discussed in the forum](https://forum.snapcraft.io/t/cleanbuild-remote-on-pi-grabs-wrong-arch-lxc-image/691/7) so container builds default to the architecture of the container rather than the client, I followed up [on a suggestion](https://github.com/snapcore/snapcraft/pull/1493) to pass the original commands instead of picking options we need by hand. This also addresses [`--no-parallel-build` being ignored when building in a container](https://forum.snapcraft.io/t/cleanbuild-no-parallel-build-exclusive/614/4). **Alternative approach to #1493**.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of #1493, which forwarded --target-arch only when explicitly set; commit 0a7de4515 preserved the container architecture default.
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of #1493, which passed --target-arch only when explicitly set in commit 0a7de4515, preserving the container architecture default.
qwen/qwen3.6-35b-a3b — — Changes to pass original CLI arguments to LXD containers were closed without merging. The fix for architecture defaults and ignored flags was abandoned as an alternative to #1493 after a discussion on sys.argv handling.
qwen3.6-35b-a3b-mtp-q6 — — Closed without merging. The PR proposed passing original CLI arguments to LXD containers to fix architecture and parallel build flags, but the approach was rejected after discussing sys.argv compatibility.

Update history

No update history recorded yet.

Related work

  • Superseded By: snapcraft#1493 (confidence 98%)

    Alternative implementation selected; its resolving commit was 0a7de4515.

Related issues

Issue Project State Summary Similarity
#1493 lxd: only pass target arch if specified explicitly snapcraft merged Merged via commit 0a7de4515, passing --target-arch to LXD only when explicitly set so builds default to the container architecture.
82%
#1718 lxd: let lxd choose the architecture snapcraft merged Merged in #1718 as 834cfce4c, delegating default container architecture selection to LXD while recording the container architecture after startup.
77%
#1439 target arch default for containers snapcraft closed Fixed by merged PR #1493 (commit 0a7de4515): LXD now defaults to the container architecture. Competing PR #1498 was closed unmerged.
73%