← Back to issue list

repo: make errors based on SnapcraftError

View original Github issue

Metadata

Project
snapcraft
Number
#1499
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1499 in commit 827d7fd82, making repo errors inherit SnapcraftError so non-debug runs report handled errors instead of tracebacks.

Resolution: closed resolved

Reason: PR #1499 was approved and merged as commit 827d7fd82. It fixes repository error handling that PR #1436 had failed to cover.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Without this change, repo-based errors result in a traceback even when not in debug mode. This should have been caught in #1436, but alas, it was not.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1499 in commit 827d7fd82, making repo errors inherit SnapcraftError so non-debug runs report handled errors instead of tracebacks.
stealth/space-bunny-alpha — closed resolved Merged PR #1499 in commit 827d7fd82, making repo errors inherit SnapcraftError so they no longer produce tracebacks outside debug mode.
qwen/qwen3.6-35b-a3b — — Merged a fix preventing repo-based errors from triggering tracebacks outside debug mode by inheriting from SnapcraftError. Approved by two reviewers, passed CI, and resolves an oversight from PR #1436.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix to make repo-based errors inherit from SnapcraftError, preventing unwanted tracebacks when debug mode is disabled. Resolves a regression overlooked in #1436.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#1436 (confidence 95%)

    Its global exception handling should have caught these repo-based errors but did not.

Related issues

Issue Project State Summary Similarity
#2602 errors: refactor exception/error handling snapcraft merged Merged PR #2602 (commit 7d0391dc5, 'errors: refactor exception/error handling') reworked snapcraft/_errors.py: always print exception messages, conditionally write tracebacks to a temp file, gate bug reporting on SNAPCRAFT_ENABLE_SILENT_REPORT, and honor error exit codes.
74%
#1788 repo: error for packages with broken dependencies snapcraft merged Merged as 9e588f51e: Snapcraft now reports an explicit unmet-dependencies error instead of silently failing for packages with broken dependencies.
72%
#2238 reporting: record the released version for errors snapcraft merged Merged in #2238 via commit fc0cdb5bf, adding the released Snapcraft version to error reports.
71%
#3983 repo: raise error when populating the apt cache directory fails snapcraft merged Merged PR #3983 in commit 341037573, making Snapcraft raise a clear error when /etc/apt cannot be copied into its cache (CRAFT-1421).
70%