repo: make errors based on SnapcraftError
Metadata
Current evaluation
Merged a fix preventing repo-based errors from triggering tracebacks outside debug mode by inheriting from SnapcraftError. Approved by two reviewers, passed CI, and resolves an oversight from PR #1436.
Suggested action: —
No scores available.
Issue body
Without this change, repo-based errors result in a traceback even when not in debug mode. This should have been caught in #1436, but alas, it was not.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix preventing repo-based errors from triggering tracebacks outside debug mode by inheriting from SnapcraftError. Approved by two reviewers, passed CI, and resolves an oversight from PR #1436. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix to make repo-based errors inherit from SnapcraftError, preventing unwanted tracebacks when debug mode is disabled. Resolves a regression overlooked in #1436. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix addressing repo-based errors that triggered unwanted tracebacks in non-debug mode. Updates error classes to inherit from SnapcraftError, resolving an oversight from PR #1436. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1815 repo: handle invalid snaps | snapcraft | merged | Merged changes handling invalid snaps in build-snaps with a clear error message. Adds retries to information fetching for improved network failure debugging. Approved after resolving a minor CI typo. | |
| #2079 repo: catch error updating the package cache | snapcraft | merged | Merged. Catches apt package cache update errors like hash mismatches and host resolution failures. Fixes #2029, #2030, and LP: #1747715 by handling exceptions, clearing the index on hash failures, and allowing Snapcraft to proceed. Includes test updates. | |
| #2734 SnapcraftError refactoring | snapcraft | merged | Refactored SnapcraftError across four files, adding 279 lines and removing 26. Approved by one reviewer and merged into the codebase. | |
| #2096 tests: don't use os_release and repo from snapcraft | snapcraft | merged | Merged PR removing os_release and repo imports from the snapcraft module in integration tests, replacing them with dedicated modules. Fixes #1982. Approved by two reviewers and merged despite a suggestion to extract shared functionality. | |
| #3 move "repo" code from snapcraft | craft-archives | closed | Merged after approval, moving the snapcraft.repo package and tests to craft_archives. Updates include switching to loggers, adding a base error class, copying utility packages, and applying stricter linting fixes. | |
| #2238 reporting: record the released version for errors | snapcraft | merged | Merged changes to record the released snapcraft version in error reports. Approved by reviewer, passed CI checks, and integrated with a 13-line update. | |
| #3974 snap config: catch more errors when config cannot be retrieved | snapcraft | merged | Merged improvements to snap configuration error handling. Follows up on PR #3971 to catch additional retrieval failures reported by users. Approved by one reviewer, passed CI checks, and updated four files (+30/-10). | |
| #2752 errors: migrate handful of errors to SnapcraftException | snapcraft | merged | Merged. Migrates multiple error classes to SnapcraftException, adds a SnapcraftReportableException helper, simplifies error messages, and updates tests. Approved by a maintainer and passed CI checks. | |
| #2270 catkin, rosdep: stop using FileNotFoundErrors | snapcraft | merged | Merged. Replaces FileNotFoundError with SnapcraftError-derived exceptions in catkin and rosdep to prevent raw tracebacks from reaching Sentry. Ensures users receive formatted error messages. Approved by one reviewer and passed CI. |