← Back to issue list

python plugin: always record constraints and requirements contents

View original Github issue

Metadata

Project
snapcraft
Number
#1521
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR canonical/snapcraft#1521 (commit 77a3a334a): the Python plugin now always records constraints.txt and requirements.txt contents in build details, following earlier build-detail recording work in #1487.

Resolution: closed resolved

Reason: The pull request was approved by sergiusens and merged as commit 77a3a334a, changing the Python plugin (+26/-8 lines, 2 files) to always record constraints and requirements file contents rather than skipping locally sourced files.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- Sergio suggested an existential question about the usefulness of recording these files if they are already tracked in the source. I made a naive implementation of ignoring the file if it's not from a remote server, but this brings more questions about when we should and when we shouldn't record the contents. If you have an opinion, please comment on the forum: https://forum.snapcraft.io/t/record-build-details-of-python-snaps/1640/4 For now, I'm just recording it always.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR canonical/snapcraft#1521 (commit 77a3a334a): the Python plugin now always records constraints.txt and requirements.txt contents in build details, following earlier build-detail recording work in #1487.
stealth/space-bunny-alpha — closed resolved Merged PR #1521 (77a3a334a) makes the Python plugin always record constraints and requirements contents in build details.
qwen/qwen3.6-35b-a3b — — Merged update to the Python plugin that unconditionally records constraints and requirements file contents. Approved by a reviewer with passing CI checks, the change modifies two files, adding 26 lines and removing 8.
qwen3.6-35b-a3b-mtp-q6 — — Merged. The Python plugin now always records constraints and requirements contents, regardless of source tracking status. This decision followed maintainer discussion to guarantee consistent build detail recording.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#1454 (confidence 80%)

    Closed tracking issue 'python plugin recording' that this change furthers

  • Likely Fixed By: canonical/snapcraft#1487 (confidence 78%)

    Prior merged PR that introduced Python plugin manifest/build-detail recording, which #1521 extends to always include constraints and requirements contents

Related issues

Issue Project State Summary Similarity
#1454 python plugin recording snapcraft closed Python plugin build-detail recording was merged in canonical/snapcraft#1487 (5887a826a); #1521 later expanded it to always record constraints.txt and requirements.txt contents.
90%
#1603110 python2 constraints for requirements snapcraft (launchpad) closed Python2 plugin gained pip constraints-file support in merged PR snapcore/snapcraft#657 (commit b26916766).
74%
#1603115 python3 constraints for requirements snapcraft (launchpad) closed Python 3 pip constraints support shipped via the unified Python plugin in canonical/snapcraft#771 (bb7bd40e1).
71%