← Back to issue list

python plugin: always record constraints and requirements contents

View original Github issue

Metadata

Project
snapcraft
Number
#1521
Type
pull request
State
merged
Author
come-maiz
Labels
Created
Updated
Closed

Current evaluation

Merged update to the Python plugin that unconditionally records constraints and requirements file contents. Approved by a reviewer with passing CI checks, the change modifies two files, adding 26 lines and removing 8.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- Sergio suggested an existential question about the usefulness of recording these files if they are already tracked in the source. I made a naive implementation of ignoring the file if it's not from a remote server, but this brings more questions about when we should and when we shouldn't record the contents. If you have an opinion, please comment on the forum: https://forum.snapcraft.io/t/record-build-details-of-python-snaps/1640/4 For now, I'm just recording it always.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged update to the Python plugin that unconditionally records constraints and requirements file contents. Approved by a reviewer with passing CI checks, the change modifies two files, adding 26 lines and removing 8.
qwen3.6-35b-a3b-mtp-q6 Merged. The Python plugin now always records constraints and requirements contents, regardless of source tracking status. This decision followed maintainer discussion to guarantee consistent build detail recording.
qwen3.6-35b-a3b-mtp-q6 Merged. The Python plugin now always records constraints.txt and requirements.txt contents during builds, overriding earlier considerations to skip locally tracked files.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1487 python plugin: record manifest snapcraft merged Merged manifest recording for the Python plugin. Approved by two reviewers, changes span 11 files with 226 additions and 34 deletions. Test assertions and conditional file recording were updated per feedback. Fixes #1454.
71%