← Back to issue list

rust plugin: record the Cargo.lock file

View original Github issue

Metadata

Project
snapcraft
Number
#1561
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1561 as commit 57e9e320a, adding Cargo.lock recording to the Rust plugin as part of the #1475 build-recording work.

Resolution: closed resolved

Reason: The approved PR was merged as commit 57e9e320a, implementing Cargo.lock recording and advancing the Rust build-recording work tracked in #1475.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Updates: #1475 - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1561 as commit 57e9e320a, adding Cargo.lock recording to the Rust plugin as part of the #1475 build-recording work.
stealth/space-bunny-alpha — closed resolved Merged as 57e9e320a, adding Cargo.lock recording to Snapcraft's Rust plugin and advancing the Rust build-recording work in #1475.
stealth/space-bunny-alpha — closed resolved Merged in snapcore/snapcraft#1561 as commit 57e9e320a, adding Cargo.lock recording to the Rust plugin as part of #1475.
qwen/qwen3.6-35b-a3b — — Merged to record the Cargo.lock file in the Rust plugin, addressing issue #1475. Approved by two reviewers, passed CI checks, and modified two files (+85/-21 lines).
qwen3.6-35b-a3b-mtp-q6 — — Merged to resolve issue #1475, the Rust plugin now records the Cargo.lock file. Authored by come-maiz, the change passed static and unit tests before integration.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#1475 (confidence 100%)

    Tracking issue explicitly updated by PR #1561.

  • Related To: snapcraft#1562 (confidence 95%)

    Companion PR merged as 1ddc34f19 to record rustup, rustc, and cargo versions for #1475.

Related issues

Issue Project State Summary Similarity
#1475 rust plugin recording snapcraft closed Rust plugin build recording shipped in merged PRs #1561 (commit 57e9e320a, records Cargo.lock) and #1562 (commit 1ddc34f19, records rustup/rustc/cargo versions). Maintainer sergiusens closed the issue on 2017-09-28.
84%
#2915 rust plugin: respect Cargo.lock if present in project snapcraft merged Merged as af326013a: standard Rust builds use Cargo.lock by passing --locked to cargo fetch and install. Follow-up #2917 corrected pull-time dependency fetching.
76%
#1562 Record rust versions snapcraft merged Merged as commit 1ddc34f19, updating the Rust plugin to record rustup, rustc, and Cargo versions; this completed the versioning portion of #1475.
71%