← Back to issue list

rust plugin: record the Cargo.lock file

View original Github issue

Metadata

Project
snapcraft
Number
#1561
Type
pull request
State
merged
Author
come-maiz
Labels
Created
Updated
Closed

Current evaluation

Merged to record the Cargo.lock file in the Rust plugin, addressing issue #1475. Approved by two reviewers, passed CI checks, and modified two files (+85/-21 lines).

Suggested action:

No scores available.

Issue body

Updates: #1475 - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to record the Cargo.lock file in the Rust plugin, addressing issue #1475. Approved by two reviewers, passed CI checks, and modified two files (+85/-21 lines).
qwen3.6-35b-a3b-mtp-q6 Merged to resolve issue #1475, the Rust plugin now records the Cargo.lock file. Authored by come-maiz, the change passed static and unit tests before integration.
qwen3.6-35b-a3b-mtp-q6 Merged to update the Rust plugin to record the Cargo.lock file, resolving issue #1475. The change passed static and unit tests and was integrated by maintainer come-maiz.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2915 rust plugin: respect Cargo.lock if present in project snapcraft merged Merged PR adds --locked flag to Rust plugin cargo commands when Cargo.lock exists. Author noted a timing bug where the lockfile check occurs too late for fetch, causing incorrect dependency resolution. A follow-up PR will fix it.
79%
#2170 rust plugin: fix cargo builds and run tests snapcraft merged Merged fixes for cargo builds in the Rust plugin along with new tests. The change updated two files with 41 additions and 10 deletions, achieving 100% diff coverage.
77%
#2917 rust plugin: fetch correct (locked) crates during pull snapcraft merged Merged fix for the rust plugin that corrected crate version fetching during pull by checking for Cargo.lock in the source directory instead of the build directory. Updated spread test to prevent regression.
73%
#1475 rust plugin recording snapcraft closed Implemented via two merged pull requests that added recording functionality to the Rust plugin. The maintainer closed the issue after the PRs were merged.
72%
#2158 rust plugin: fix cargo builds and run tests snapcraft closed Changes to fix cargo builds and add tests to the Rust plugin were closed and superseded by PR #2170 after the author discovered cargo test conflicts with cross-compilation, requiring a rework.
72%
#1562 Record rust versions snapcraft merged Merged after one reviewer approval and passing CI checks. The changes record Rust versions across two files with 56 additions and 12 deletions, addressing part of issue #1475.
71%