← Back to issue list

Make it possible to use the cmake ninja generator

View original Github issue

Metadata

Project
snapcraft
Number
#1579
Type
pull request
State
closed
Author
aleixpol
Labels
Created
Updated
Closed

Current evaluation

Closed due to failing unit tests and lack of follow-up. The cmake plugin refactoring to support the ninja generator was abandoned pending necessary fixes.

Suggested action:

No scores available.

Issue body

Refactors the cmake plugin into a base class that will be used by the make and ninja variants. Includes a ninja plugin that can potentially be reused by others

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Closed due to failing unit tests and lack of follow-up. The cmake plugin refactoring to support the ninja generator was abandoned pending necessary fixes.
qwen3.6-35b-a3b-mtp-q6 Closed without merging due to failing unit tests and lack of updates. The cmake ninja generator refactoring was abandoned pending necessary fixes.
qwen3.6-35b-a3b-mtp-q6 Closed due to failing unit tests and lack of follow-up activity. The cmake plugin refactoring to support ninja and make generators was abandoned pending fixes. Maintainers invited reopening once issues are resolved.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3165 Update cmake plugin to support Ninja generator snapcraft merged Merged. Adds a cmake-generator plugin option to enable Ninja builds, leveraging CMake 3.15+ features. Reviewer suggestions were acknowledged, and the update was successfully integrated.
74%