Removed dependency on VERSION_ID in os-release
Metadata
Current evaluation
Merged PR #1623 as b335ed471, allowing _get_system_libs to handle missing os-release VERSION_ID and treat the exclusion list as absent; fixes LP #1722650.
Resolution: closed resolved
Reason: PR #1623 was merged in commit b335ed471. The change removes the required VERSION_ID lookup and handles its absence as a missing shared-library exclusion file.
Evaluated by: mr-cal-bot
No scores available.
Issue body
_get_system_libs depends on VERSION_ID for the name of the file that is
expected to contain the list of shared libraries to exclude from the build.
However, according to os-release(5), VERSION_ID is just optional, so its
absence should not cause failures.
With this commit, the absence of VERSION_ID is considered as the file
with the list of shared libraries to be excluded does not exist.
Fixes https://bugs.launchpad.net/snapcraft/+bug/1722650
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1623 as b335ed471, allowing _get_system_libs to handle missing os-release VERSION_ID and treat the exclusion list as absent; fixes LP #1722650. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #1623 as b335ed471: _get_system_libs now treats missing os-release VERSION_ID as no exclusion file, fixing Launchpad bug #1722650. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1623 in commit b335ed471, removing the VERSION_ID dependency and treating its absence as no shared-library exclusion file. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1623 as b335ed471: _get_system_libs no longer requires VERSION_ID, treating its absence as no shared-library exclusion file. Fixes Launchpad #1722650. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Resolves a failure when VERSION_ID is missing from os-release by gracefully treating its absence as a missing exclusion file. Fixes Launchpad bug 1722650. Approved by two reviewers and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix removing the hard dependency on the optional VERSION_ID field in os-release. Missing VERSION_ID is now treated as a non-existent exclusion file, preventing build failures and resolving Launchpad bug 1722650. |
Update history
No update history recorded yet.
Related work
-
Related To:
Launchpad#1722650
(confidence 100%)
The PR description explicitly states that it fixes this Launchpad bug.
Related issues
No related issues found above the similarity threshold.