← Back to issue list

lxd: fix the unit test for the user id map

View original Github issue

Metadata

Project
snapcraft
Number
#1629
Type
pull request
State
merged
Author
come-maiz
Labels
Created
Updated
Closed

Current evaluation

Merged a fix for an LXD unit test failure when run as root, introduced in #1588. Adjusts the user ID map test logic. Approved by two reviewers and passed CI. One remaining test error was noted but did not block the merge.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- #1588 introduced an error in this test when it is executed as root.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix for an LXD unit test failure when run as root, introduced in #1588. Adjusts the user ID map test logic. Approved by two reviewers and passed CI. One remaining test error was noted but did not block the merge.
qwen3.6-35b-a3b-mtp-q6 Merged fix for LXD unit test failures in user ID mapping when executed as root. Resolved errors introduced in PR #1588, with one remaining test failure deferred to another contributor.
qwen3.6-35b-a3b-mtp-q6 Merged to resolve a unit test failure in the LXD user ID map module when executed as root, introduced by PR #1588. One remaining test error was noted and deferred to another maintainer.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1385 lxd: Don't assume user ID to 1000 for raw.idmap snapcraft merged Merged fix for LXD raw.idmap that incorrectly assumed user ID 1000. Resolves bug 1700703. Approved by reviewers and validated across environments.
79%
#1588 lxd: use SUDO_UID for ID mapping snapcraft merged Merged a one-file change implementing SUDO_UID for LXD ID mapping, resolving bug 1719996. The pull request passed CI, received approval from one reviewer with no unresolved comments, and was successfully integrated.
78%
#1516 lxd: LXD not installed when using remote snapcraft merged Merged fix for a bug where lxc installation was not correctly verified when using a LXD remote. Also corrected incomplete test scenario usage. Approved by two reviewers, modified two files.
73%
#552 Make the lxd unit test pass in architectures other than amd64. snapcraft merged Merged a +3/-1 change to fix lxd unit tests for non-amd64 architectures. Resolved LP #1589747 after a retest request.
71%
#1904 lxd: raw.idmap expects host and container id respectively snapcraft merged Merged a fix correcting raw.idmap syntax in LXD configuration. The change maps host and container IDs correctly, preventing container files from being owned by root. Resolves LP: #1741753 with a four-line adjustment across two files.
70%