← Back to issue list

libraries: exclude the full set of libc6

View original Github issue

Metadata

Project
snapcraft
Number
#1632
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1632 (commit 1b8ea95c7): snapcraft/internal/libraries.py now excludes every library from the libc6 deb, not just libc.so.6, stopping partial host glibc leaking into classic snaps; later reworked by #1744.

Resolution: closed resolved

Reason: The PR was merged as commit 1b8ea95c7 ('libraries: exclude the full set of libc6'), replacing the hardcoded frozenset(['libc.so.6']) with the full library list from repo.Repo.get_package_libraries('libc6'). It landed alongside #1635, which removed LD_LIBRARY_PATH leaking from snapcraft-classic and caused Trusty failures.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1632 (commit 1b8ea95c7): snapcraft/internal/libraries.py now excludes every library from the libc6 deb, not just libc.so.6, stopping partial host glibc leaking into classic snaps; later reworked by #1744.
stealth/space-bunny-alpha — closed resolved Merged PR #1632 as commit 1b8ea95c7, replacing the single libc.so.6 exclusion with the full libc6 library set to prevent host libraries from entering classic snaps.
qwen/qwen3.6-35b-a3b — — Merged changes to exclude the full libc6 library set from snaps, replacing the previous single-library exclusion. This resolves an LD_LIBRARY_PATH error on Trusty and prevents unintended host library leakage.
qwen3.6-35b-a3b-mtp-q6 — — Merged to exclude the full libc6 library set from snaps, replacing the previous single-library exclusion. Resolves a Trusty-specific LD_LIBRARY_PATH error in snapcraft-classic and prevents partial host library inclusion, addressing issue #1635.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#1635 (confidence 90%)

    Merged PR removing LD_LIBRARY_PATH leakage from snapcraft-classic; sergiusens cited it as the other problem behind the original suspicions on this PR.

  • Superseded By: snapcraft#1744 (confidence 80%)

    Commit ec7ba948a 'elf: conversion from libraries' later converted this libraries.py logic to ELF-based library handling, replacing the libc6 deb-based approach.

Related issues

Issue Project State Summary Similarity
#1881 elf: better handling for newer libc6 snapcraft merged Merged in snapcraft#1881 (commit 10ab28277), requiring libc6 to be explicitly declared in snapcraft.yaml so newer libc6 dependencies are recorded correctly.
72%
#1231 pluginhandler: exclude `/snap/` from libraries. snapcraft merged Merged snapcraft#1231 in commit 0e9b5a84e, excluding /snap/ paths from classic-confinement library collection to avoid bundling libraries from installed snaps.
71%
#1635 snap: remove leaking LD_LIBRARY_PATH snapcraft merged Merged as da9181487: PR #1635 removed LD_LIBRARY_PATH leakage from snapcraft-classic, fixing LP #1723208 and preventing breakage on hosts such as Trusty.
71%
#1554015 adding lib6-dev to stage-package directly or indirectly breaks build in snapcraft (only) snapcraft (launchpad) closed Staged libc6-dev was identified as the build breaker. Proposed exclusion PR canonical/snapcraft#1951 was closed unmerged over ROS/Catkin compatibility concerns, so no fix landed.
71%