Translated the plainbox tests to python.

Metadata

Project: snapcraft
Number: #166
Type: pull request
State: closed
Author: come-maiz
Labels: —
Created: 2015-12-16 07:24 AM UTC
Updated: 2015-12-18 05:57 PM UTC
Closed: 2015-12-18 05:52 PM UTC

Current evaluation

PR #166 (plainbox tests to Python) was closed unmerged and superseded by PR #173 from elopio's rerebased_py_integration branch, which merged in commit 96d3ea92f (implementation 0794c2741).

Resolution: closed superseded

Reason: The work was re-submitted as PR #173 from elopio's rebase branch and merged in commit 96d3ea92f (implementation commit 0794c2741, +1293/-561 across 147 files). Maintainer come-maiz celebrated with "\o/ greeeeen!" and reviewer kyrofa asked "Can this be closed, then?", so #166 was closed in favour of the merged #173.

Evaluated by: mr-cal-bot

No scores available.

Issue body

There are still a couple of things that I don't understand, and plenty of things that I would like to clean up and split. But in this PR I just focused on a literal translation, to start improving the tests in future PRs. In particular it's bad that the generated binaries can't be executed in trusty. On the plainbox execution we were ignoring the exit code, so for now I'm just doing the same in python. Marked with a TODO to dig further on the cause.

Evaluation history

Date	Model	Scores	Action	Summary
2026-10-03 07:05 AM UTC	stealth/space-bunny-alpha	—	closed superseded	PR #166 (plainbox tests to Python) was closed unmerged and superseded by PR #173 from elopio's rerebased_py_integration branch, which merged in commit 96d3ea92f (implementation 0794c2741).
2026-09-25 04:11 AM UTC	stealth/space-bunny-alpha	—	closed resolved	Merged PR #173 translated the plainbox tests to Python in commit 0794c2741 (merge 96d3ea92f), adding 1,293 and removing 561 lines across 147 files.
2026-07-22 03:00 PM UTC	qwen/qwen3.6-35b-a3b	—	—	Merged after passing CI. Translated plainbox tests to Python, preserving original behavior and temporarily ignoring exit codes. Reviewer approved closure following successful builds.
2026-07-21 05:56 AM UTC	qwen3.6-35b-a3b-mtp-q6	—	—	Merged the literal translation of plainbox tests to Python. CI passed successfully. Trusty binary compatibility and exit code handling were deferred with TODOs for future improvements.

Update history

No update history recorded yet.

Related work

Superseded By: canonical/snapcraft#173 (confidence 97%)
Same title and diff size; merged PR from elopio's rerebased_py_integration branch containing commit 0794c2741, merge 96d3ea92f.
Likely Fixed By: canonical/snapcraft#173 (confidence 90%)
The Python-translated plainbox tests actually landed via this merged PR.

Related issues

Issue	Project	State	Summary	Similarity
#173 Translated the plainbox tests to python.	snapcraft	merged	Merged the Plainbox test conversion to Python in PR #173 (+1,293/-561 across 147 files); implementation commit 0794c2741 landed via merge 96d3ea92f.	89%