← Back to issue list

Translated the plainbox tests to python.

View original Github issue

Metadata

Project
snapcraft
Number
#166
Type
pull request
State
closed
Author
come-maiz
Labels
Created
Updated
Closed

Current evaluation

Merged after passing CI. Translated plainbox tests to Python, preserving original behavior and temporarily ignoring exit codes. Reviewer approved closure following successful builds.

Suggested action:

No scores available.

Issue body

There are still a couple of things that I don't understand, and plenty of things that I would like to clean up and split. But in this PR I just focused on a literal translation, to start improving the tests in future PRs. In particular it's bad that the generated binaries can't be executed in trusty. On the plainbox execution we were ignoring the exit code, so for now I'm just doing the same in python. Marked with a TODO to dig further on the cause.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after passing CI. Translated plainbox tests to Python, preserving original behavior and temporarily ignoring exit codes. Reviewer approved closure following successful builds.
qwen3.6-35b-a3b-mtp-q6 Merged the literal translation of plainbox tests to Python. CI passed successfully. Trusty binary compatibility and exit code handling were deferred with TODOs for future improvements.
qwen3.6-35b-a3b-mtp-q6 Merged and closed after tests passed. Translated plainbox tests to Python, preserving existing exit code handling. Known issues with binary execution on Trusty were noted with TODOs for future fixes.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#173 Translated the plainbox tests to python. snapcraft merged Merged maintainer come-maiz's translation of plainbox tests to Python. The change modifies 147 files, adding 1293 lines and removing 561, with no review comments or CI checks recorded.
83%
#2799 Plainbox test updates snapcraft merged Merged plainbox test updates involving minor changes across three files. Approved by one reviewer with zero unresolved comments and no CI failures.
75%
#1642 tests: move the plainbox test to the integration suite snapcraft merged Merged changes to move the plainbox test to the integration suite. Updated expected namespace results to remove outdated year prefixes, fixing a test failure caused by upstream plainbox changes. Approved and passed CI.
72%