← Back to issue list

tests: add the missing quote on autopkgtest run

View original Github issue

Metadata

Project
snapcraft
Number
#1756
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR snapcraft#1756 restored a missing quote in the local autopkgtest command, fixing a one-character syntax error in commit ab5e6e37b.

Resolution: closed resolved

Reason: The one-character quoting fix was approved and merged in snapcraft#1756 as commit ab5e6e37b, restoring local execution of the autopkgtest suite.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- I must have touched backspace by mistake when I was moving the suite to the nightly, or something, because this worked here: https://travis-ci.org/snapcore/snapcraft/jobs/302748980 I'm sorry. I added the quote, and now I can run this locally: http://paste.ubuntu.com/26029313/ Hopefully travis will not give us any other surprises.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR snapcraft#1756 restored a missing quote in the local autopkgtest command, fixing a one-character syntax error in commit ab5e6e37b.
stealth/space-bunny-alpha — closed resolved Merged PR #1756 restored a missing quote in the autopkgtest run test command, fixing a one-character syntax error that prevented local test execution.
qwen/qwen3.6-35b-a3b — — Merged a single-line fix adding a missing quote to the autopkgtest run command. Approved and passed CI, resolving a syntax error that broke test execution.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix for a missing quote in the autopkgtest run command. The syntax error was accidentally introduced during a suite migration. Local and Travis tests now pass successfully.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1603 tests: add /snap/bin to PATH in autopkgtests snapcraft merged Merged PR #1603 (commit 70a0c6fb1) into master, adding /snap/bin to PATH in the autopkgtest setup so integration tests could find snap binaries; it depended on #1595, also merged.
73%
#2380 tests: use autopkgtest to leverage snap testing snapcraft merged Merged #2380 as commit 4c5b97a6b, updating 31 files to use autopkgtest for snap testing.
72%
#1570992 autopkgtests are running snapcraft from source snapcraft (launchpad) closed Fixed by upstream PR #464 (commit bce2d23ec) making autopkgtests run against the installed snapcraft package instead of the source tree. Shipped in snapcraft 2.8.8b xenial SRU; verified and released to -updates.
72%
#1849 tests: add snap not found tests snapcraft merged Merged missing-snap test coverage; snapcraft PR #1849 landed as commit 54cf2bd9e.
71%
#1680960 the retry autopkg test script is failing because it can't find the needed script to make the request snapcraft (launchpad) closed Fixed by merged PR snapcraft#1243 (commit e01c00991), updating the retry autopkgtest helper to use the relocated upstream retry-github-test script.
70%
#1716 tests: split the integration autopkgtests snapcraft merged Merged in snapcraft#1716 via 57af155a7, splitting integration autopkgtests into separate runs to prevent timeout failures despite added setup overhead.
70%