← Back to issue list

many: ensure classic confined binaries use the correct interpreter

View original Github issue

Metadata

Project
snapcraft
Number
#1759
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged. Resolves #1662 by correcting the ELF interpreter path for classic confined binaries during the prime step. Approved by reviewers and passed CI checks.

Suggested action:

No scores available.

Issue body

During the prime step, the pluginhandler collects all elf files, as a postprocessing step, the elf files that contain an .interp section in the elf headers are set to use the linker loader from core. Fixes: #1662 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- I have built a snap (but still sets the LD_FLAG) which can be obtained by `snap install snapcraft --classic --channel edge/patchelf`

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Resolves #1662 by correcting the ELF interpreter path for classic confined binaries during the prime step. Approved by reviewers and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged. Resolves #1662 by modifying the prime step to set the core linker loader for ELF interp sections in classic confined binaries. Approved after passing tests and review.
qwen3.6-35b-a3b-mtp-q6 Merged. Modifies the prime step to update ELF interp sections, ensuring classic confined binaries use the core linker loader. Resolves issue #1662. Approved after review despite one flaky test.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1189 core: resolve ld link first. snapcraft merged Merged a fix for classic confinement builds that checks for symbolic links on the ld executable before verifying its existence. Integrated despite unrelated CI failures and pending reviews.
70%