← Back to issue list

Make the pip filtering in the Python plugin more fine-grained

View original Github issue

Metadata

Project
snapcraft
Number
#1763
Type
pull request
State
merged
Author
OddBloke
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1763 in commit a1fb1aeac, refining Python plugin filters so scripts such as pip2pi are retained while pip artifacts are filtered.

Resolution: closed resolved

Reason: PR #1763 was approved and merged as commit a1fb1aeac, fixing the overbroad pip-prefix filtering in the Python plugin.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This allows Python scripts that begin with "pip" but aren't actually pip (such as pip2pi and friends) to be included in snaps using the Python part. LP: #1734213 - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1763 in commit a1fb1aeac, refining Python plugin filters so scripts such as pip2pi are retained while pip artifacts are filtered.
stealth/space-bunny-alpha — closed resolved Merged PR #1763 via commit a1fb1aeac, refining Python plugin pip filters so scripts such as pip2pi are included.
qwen/qwen3.6-35b-a3b — — Merged. Updates the Python plugin to use fine-grained pip filtering, allowing non-pip scripts starting with pip to be included in snaps. Resolves LP #1734213. Approved by reviewer and passed CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes to refine pip filtering in the Python plugin. The update allows non-pip scripts starting with pip, such as pip2pi, to be included in snaps. The pull request passed static and unit tests and was successfully integrated.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.