← Back to issue list

store: refactor acquirement of attenuated macaroon

View original Github issue

Metadata

Project
snapcraft
Number
#1765
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1765 as commit 72cf77f1b, refactoring attenuated-macaroon acquisition into reusable store code, resolving #1709 and enabling use beyond enable-ci Travis.

Resolution: closed resolved

Reason: Approved PR #1765 was merged as commit 72cf77f1b. Its description explicitly states that the refactor resolved #1709 and paved the way for using attenuated macaroons outside enable-ci Travis.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- This PR resolves #1709, paving the way toward using attenuated macaroons outside of just `enable-ci travis`.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1765 as commit 72cf77f1b, refactoring attenuated-macaroon acquisition into reusable store code, resolving #1709 and enabling use beyond enable-ci Travis.
stealth/space-bunny-alpha — closed resolved Merged PR #1765 (commit 72cf77f1b) refactored attenuated-macaroon acquisition and resolved #1709, enabling reuse beyond enable-ci Travis.
qwen/qwen3.6-35b-a3b — — Merged after refactoring attenuated macaroon acquisition in the store module. Resolves issue #1709, enabling broader macaroon usage beyond Travis CI. Approved by one reviewer, passed CI, and modified eight files.
qwen3.6-35b-a3b-mtp-q6 — — Merged refactor of attenuated macaroon acquisition in the store module. Resolves #1709 and enables attenuated macaroons outside Travis CI environments.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: snapcraft#1709 (confidence 100%)

    PR #1765 explicitly resolves the macaroon-retrieval refactor requested in issue #1709.

Related issues

Issue Project State Summary Similarity
#1709 Extract macaroon retrieval into more generic place snapcraft closed Maintainer refactor task to move macaroon retrieval into a more generic location was implemented and closed by PR #1765, merged as commit 72cf77f1b ("store: refactor acquirement of attenuated macaroon").
78%