← Back to issue list

store: refactor acquirement of attenuated macaroon

View original Github issue

Metadata

Project
snapcraft
Number
#1765
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged after refactoring attenuated macaroon acquisition in the store module. Resolves issue #1709, enabling broader macaroon usage beyond Travis CI. Approved by one reviewer, passed CI, and modified eight files.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- This PR resolves #1709, paving the way toward using attenuated macaroons outside of just `enable-ci travis`.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after refactoring attenuated macaroon acquisition in the store module. Resolves issue #1709, enabling broader macaroon usage beyond Travis CI. Approved by one reviewer, passed CI, and modified eight files.
qwen3.6-35b-a3b-mtp-q6 Merged refactor of attenuated macaroon acquisition in the store module. Resolves #1709 and enables attenuated macaroons outside Travis CI environments.
qwen3.6-35b-a3b-mtp-q6 Merged refactoring of attenuated macaroon acquisition in the store module. Resolves #1709 by decoupling macaroon handling from Travis CI, enabling broader usage across the codebase.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#532 feat: add 'macaroon' secret type fetch-service merged Merged addition of a 'macaroon' secret type to align with Store implementation. Requires base64-encoded input. Approved by two reviewers, passed CI checks, and merged despite one failing test. Modified 11 files.
72%