tests: move refresh to unit folder
Metadata
Current evaluation
Merged as 855c619a: a one-line change moving tests/commands/refresh_test.py into the unit test folder so it runs in regular test runs, which had let #1769 pass CI despite a regression.
Resolution: closed resolved
Reason: The PR itself was merged into master as commit 855c619a ("tests: move refresh to unit folder (#1787)"), after approval by a maintainer, relocating the refresh test so the test suite actually executes it.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Somehow the refresh test ended up in a folder that's not part of the new structure so it wouldn't run as part of the regular test runs, which allowed #1769 to pass when it shouldn't have.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as 855c619a: a one-line change moving tests/commands/refresh_test.py into the unit test folder so it runs in regular test runs, which had let #1769 pass CI despite a regression. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #1787 as 855c619a, moving the refresh test into the unit folder so regular test runs execute it and catch the #1769 false pass. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1787 (855c619a) moved the refresh test into the unit folder so it runs in the regular test suite, exposing the gap behind #1769. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix moving a misplaced refresh test into the unit folder. The test was previously excluded from regular runs due to the new directory structure, causing false passes. Approved by one reviewer, passed CI, and merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix that moves a misplaced refresh test to the unit folder. This corrects test discovery, ensuring execution during regular runs and preventing false passes in related changes. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#1769
(confidence 80%)
Referenced in the PR body as the change that wrongly passed CI because the refresh test sat outside the unit test folder.
Related issues
No related issues found above the similarity threshold.