tests: move refresh to unit folder
Metadata
Current evaluation
Merged a fix moving a misplaced refresh test into the unit folder. The test was previously excluded from regular runs due to the new directory structure, causing false passes. Approved by one reviewer, passed CI, and merged.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Somehow the refresh test ended up in a folder that's not part of the new structure so it wouldn't run as part of the regular test runs, which allowed #1769 to pass when it shouldn't have.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix moving a misplaced refresh test into the unit folder. The test was previously excluded from regular runs due to the new directory structure, causing false passes. Approved by one reviewer, passed CI, and merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix that moves a misplaced refresh test to the unit folder. This corrects test discovery, ensuring execution during regular runs and preventing false passes in related changes. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes relocating the refresh test to the unit folder. This corrected the test suite structure, ensuring regular execution and preventing the flawed #1769 test from incorrectly passing. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5375 test: fix command tests | snapcraft | merged | Merged after updating test fixtures to resolve failing command unit tests. Approved by two reviewers, passed CI checks, and modified two files with 17 additions and 9 deletions. | |
| #60 tests: move test data to a common location | craft-archives | merged | Merged following reviewer approval and passing CI. Relocates test data to a common directory, resolving issue #39. Modifies 13 files with zero coverage impact. | |
| #3305 unit tests: fix runtests.sh not filtering tests when passed a subdirectory | snapcraft | merged | Merged a one-line fix correcting runtests.sh to properly filter tests when a subdirectory is passed. Previously, the script ran the entire suite. Approved by two reviewers, passed CI, and merged. | |
| #3719 tests: fix lifecycle tests to run on new directory | snapcraft | merged | Merged a fix for lifecycle tests to run in a new directory instead of the current one. Approved by a reviewer, passed CI, and changed three lines. | |
| #1928 tests: remove duplicate tests | snapcraft | merged | Merged changes that remove duplicate tests and clarify test base class names to prevent future duplication. Approved by two reviewers, passed CI, and reduced unit test execution time. | |
| #1027 tests: fix broken unit test in master | snapcraft | merged | Merged a one-line fix resolving a broken unit test in master. Approved by one reviewer with no unresolved comments. Changes passed CI and maintained 96.37% code coverage. Integrated directly into the main branch. | |
| #983 test: make retry unit test more deterministic | craft-providers | merged | Merged. Changes refactor a retry unit test for improved determinism. Approved by a reviewer, passed CI checks, and updated one file (+58/-9). | |
| #3662 tests: update spread url | snapcraft | merged | Merged update to spread tarball URLs in test files. Approved by a reviewer, passed CI checks, modified two files with minimal changes, and maintained existing code coverage. | |
| #461 test: improve test coverage | fetch-service | merged | Merged to improve test coverage, adding 270 lines across three files. Approved by two reviewers with all CI checks passing. | |
| #167 tests: move test module from unit/ to integration/ | craft-cli | merged | Merged the move of test_messages_integration from unit/ to integration/. Updated coverage to include integration tests, disabled the local fail_under check, and relies on GitHub coverage. Approved and passed CI. |