← Back to issue list

project: refactor storeapi

View original Github issue

Metadata

Project
snapcraft
Number
#1793
Type
pull request
State
merged
Author
daniellimws
Labels
Created
Updated
Closed

Current evaluation

Merged refactoring that split three snapcraft.storeapi classes from __init__.py into separate modules. Approved by a reviewer, passed CI, and resolved commit sync and dependency issues prior to merge.

Suggested action:

No scores available.

Issue body

Refactor the 3 classes in `__init.py__` in the snapcraft.storeapi package into 3 different modules and expose those modules in `__init__.py` - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged refactoring that split three snapcraft.storeapi classes from __init__.py into separate modules. Approved by a reviewer, passed CI, and resolved commit sync and dependency issues prior to merge.
qwen3.6-35b-a3b-mtp-q6 Merged refactoring of three snapcraft.storeapi classes from __init__.py into separate modules. Author resolved commit synchronization and local dependency issues before final merge.
qwen3.6-35b-a3b-mtp-q6 Merged after refactoring snapcraft.storeapi classes into separate modules. Required test adaptations, branch synchronization, and commit cleanup to resolve history conflicts and dependency issues before final merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3686 storeapi: export SnapAPI snapcraft merged Merged into snapcraft/7.0 after maintainer approval. Exports the SnapAPI from the storeapi module across four files. CI passed, review approved, and code coverage increased by 0.05%.
76%
#3667 storeapi: fix typo snapcraft merged Merged a single-line typo correction in the storeapi module. Approved by a reviewer, passed CI, and increased test coverage by 0.07%.
72%
#3692 legacy storeapi: use craft-store snapcraft merged Merged PR replaces the legacy storeapi HTTP client with craft-store, removes obsolete tests and logout calls, and adapts the codebase to craft-store API changes. Approved and passed CI.
72%
#3448 storeapi: rename SnapClientIndex to SnapAPI snapcraft merged Merged changes renaming SnapClientIndex to SnapAPI to align with the api.snapcraft.io client interface. Docstrings were updated across six files. Approved by a reviewer and passed all CI checks.
71%
#2056 Fix formatting of some store errors snapcraft merged Merged after PR #2050 landed first. Fixed SnapcraftError formatting that crashed __str__ on pre-formatted strings with braces. Author rebased and added tests for StoreReviewError and StoreMetadataError fixes. Approved and passed CI.
70%