cli: add expiration option to export-login
Metadata
Current evaluation
Merged as PR #1831 (commit 133ba03d), adding an ISO 8601 --expires option to `snapcraft export-login` and refactoring store error handling to surface expiration validation errors.
Resolution: closed resolved
Reason: PR #1831 was merged by maintainers kyrofa/come-maiz after discussion settled on ISO 8601 as the expiration format (dropping dateutil), with commit 133ba03d landing the feature. The PR also refactored store error handling so invalid expiration times surface the store's validation errors instead of appearing as incorrect passwords, and added a manual test verifying the requested expiration is echoed back.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
With this PR one can e.g. call `snapcraft export-login --expires=2018-01-01T00:00:00` and export a login that is only valid until the first of the year.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as PR #1831 (commit 133ba03d), adding an ISO 8601 --expires option to `snapcraft export-login` and refactoring store error handling to surface expiration validation errors. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #1831 via commit 133ba03d, adding ISO 8601 --expires support to export-login and surfacing store validation errors. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Adds --expires to snapcraft export-login, enforcing strict ISO 8601 datetime formats. Removes dateutil dependency, refactors store error handling to surface validation failures, and adds a manual expiration test. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Adds --expires option to snapcraft export-login CLI. Uses strict ISO 8601 format, removes dateutil dependency, and refactors store error handling to surface validation errors. Includes manual expiration test. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2493 cli: specify default expiration for export-login | snapcraft | closed | Closed unmerged after a maintainer requested a specific default expiry and clearer help/output; the author could reopen once those concerns were addressed (#2493). | |
| #1780 cli: add export-login command | snapcraft | merged | Merged as commit 53027208d ("cli: add export-login command (#1780)"), adding snapcraft export-login plus a --with option to login, closing #1711 and the abandoned enable-ci approach. |