← Back to issue list

lxd: Change "Terminating" message to debug level

View original Github issue

Metadata

Project
snapcraft
Number
#1842
Type
pull request
State
merged
Author
kalikiana
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1842 in commit 1d3e50c4c, lowering the LXD "Terminating" log message from normal output to debug level.

Resolution: closed resolved

Reason: The change was merged via commit 1d3e50c4c, which records PR #1842 and lowers the LXD "Terminating" message to debug level.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- As discussed briefly in a hangout with @sergiusens the "Terminating..." message should be a debug message. We don't currently have unit tests for unexpected messages so I'm not touching the tests (@elopio please correct me if I'm wrong on this one).

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1842 in commit 1d3e50c4c, lowering the LXD "Terminating" log message from normal output to debug level.
stealth/space-bunny-alpha — closed resolved Merged #1842 via commit 1d3e50c4c, lowering the LXD "Terminating" message from normal output to debug level.
stealth/space-bunny-alpha — closed resolved Merged PR #1842 as commit 1d3e50c4c, lowering the LXD "Terminating" log message from normal output to debug level.
stealth/space-bunny-alpha — closed resolved Merged #1842 via commit 1d3e50c4c, changing LXD's "Terminating" log message to debug level to reduce normal output.
qwen/qwen3.6-35b-a3b — — Merged changes that downgrade the LXD Terminating log message to debug level. Approved by three reviewers and passed CI, reducing unnecessary console output.
qwen3.6-35b-a3b-mtp-q6 — — Merged change adjusting LXD Terminating log output to debug level. Contributor kalikiana verified static and unit tests. No further discussion required.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#161 lxd: improve error messages craft-providers merged Merged PR #161 consolidated duplicate LXD error messages and added help text to other errors in commit 18d4470.
75%