← Back to issue list

lxd: Change "Terminating" message to debug level

View original Github issue

Metadata

Project
snapcraft
Number
#1842
Type
pull request
State
merged
Author
kalikiana
Labels
Created
Updated
Closed

Current evaluation

Merged changes that downgrade the LXD Terminating log message to debug level. Approved by three reviewers and passed CI, reducing unnecessary console output.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- As discussed briefly in a hangout with @sergiusens the "Terminating..." message should be a debug message. We don't currently have unit tests for unexpected messages so I'm not touching the tests (@elopio please correct me if I'm wrong on this one).

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes that downgrade the LXD Terminating log message to debug level. Approved by three reviewers and passed CI, reducing unnecessary console output.
qwen3.6-35b-a3b-mtp-q6 Merged change adjusting LXD Terminating log output to debug level. Contributor kalikiana verified static and unit tests. No further discussion required.
qwen3.6-35b-a3b-mtp-q6 Merged an external contribution to downgrade the LXD "Terminating" log message to debug level, reducing console noise. No test updates were included due to missing assertions for unexpected log outputs.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1771 lxd: suppress traceback when lxc launch / init fails snapcraft merged Merged to suppress tracebacks when lxc launch or init fails, relying on lxc's native error output. Approved by one reviewer, modifying three files (+35/-15).
74%
#1647 lxd: better surfacing of errors snapcraft merged Merged. Resolves duplicate error printing in LXD by having callers return silent errors with proper exit codes, allowing callees to handle message display. Approved and merged after CI validation.
72%
#3112 spread: remove dead code for lxd setup and add debug prints snapcraft merged Merged removal of redundant elif dead code in LXD setup logic and addition of debug prints for LXD snap install failures. Approved by one reviewer, passed CI checks, and integrated.
71%