← Back to issue list

Fixes for Errors

View original Github issue

Metadata

Project
snapcraft
Number
#1848
Type
pull request
State
closed
Author
Tanesh1701
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged in favor of an earlier PR; its unrelated HACKING.md edit was rejected.

Resolution: closed superseded

Reason: Maintainer kyrofa closed the PR and instructed Tanesh1701 to push the fixes to the other, earlier PR, which already contained the review history. No commit was merged here, and the HACKING.md change was explicitly excluded.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of an earlier PR; its unrelated HACKING.md edit was rejected.
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of an earlier PR: kyrofa asked Tanesh1701 to continue there and rejected the unrelated HACKING.md edit.
stealth/space-bunny-alpha — closed superseded Closed unmerged; maintainer asked the author to move the fixes to the original PR and split the unrelated HACKING.md correction into a separate PR.
stealth/space-bunny-alpha — closed superseded Closed without merging: the contributor was asked to move the fixes into the earlier PR, keep HACKING.md changes separate, and stop opening replacement PRs.
qwen/qwen3.6-35b-a3b — — Closed without merging. Reviewer directed the author to push updates to an existing pull request instead of opening duplicates, and requested the documentation fix be submitted separately.
qwen3.6-35b-a3b-mtp-q6 — — Closed and superseded by another PR. Maintainer directed the author to push iterative fixes to the original PR branch instead of opening duplicates. Changes were moved to the existing PR, and documentation updates were requested separately.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2725 Update HACKING.md snapcraft closed The unmerged two-line HACKING.md update was left at pending review with no comments or CI, and repository history shows no resolving commit for #2725.
72%