← Back to issue list

storeapi: add docstrings to _client

View original Github issue

Metadata

Project
snapcraft
Number
#1851
Type
pull request
State
merged
Author
daniellimws
Labels
Created
Updated
Closed

Current evaluation

Merged. Added reST docstrings to the storeapi _client module. Reviewers approved the changes, noting future migration to type hints and prose docstrings. CI passed and the code was integrated.

Suggested action:

No scores available.

Issue body

Add reST docstrings to _client I'm not sure what to do for kwargs, so I've left them out for now. - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Added reST docstrings to the storeapi _client module. Reviewers approved the changes, noting future migration to type hints and prose docstrings. CI passed and the code was integrated.
qwen3.6-35b-a3b-mtp-q6 Merged after adding reST docstrings to the _client module in storeapi. Reviewers approved the changes and noted a future migration to type hints and prose documentation, but the contribution was integrated as-is.
qwen3.6-35b-a3b-mtp-q6 Merged after adding reST docstrings to the storeapi _client module. Reviewers approved the documentation, noting a future migration to type hints and prose-style comments, but confirmed the changes are ready for integration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3667 storeapi: fix typo snapcraft merged Merged a single-line typo correction in the storeapi module. Approved by a reviewer, passed CI, and increased test coverage by 0.07%.
75%
#3272 storeapi: improve to channel map docstrings snapcraft merged Merged updates to storeapi channel map docstrings, aligning them with PEP 257 guidelines. Approved by one reviewer with no unresolved comments. The change affects one file, reducing 19 lines and adding 7.
75%
#1855 storeapi: add docstrings for _snap_index_client.py snapcraft merged Merged after approval by one reviewer and passing CI checks. Added docstrings to _snap_index_client.py, adding 32 lines. The external contributor's documentation update was successfully integrated.
71%