← Back to issue list

lxd: always (re-)injects snaps

View original Github issue

Metadata

Project
snapcraft
Number
#1865
Type
pull request
State
merged
Author
kalikiana
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1865 as e99354492, fixing LP #1741752 by ensuring LXD re-injects required snaps when needed.

Resolution: closed resolved

Reason: PR #1865 merged into canonical/snapcraft as commit e99354492. Its implementation always re-injects needed snaps, resolving the stated LP #1741752 bug.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- Fixes: [LP: #1741752](https://bugs.launchpad.net/snapcraft/+bug/1741752)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1865 as e99354492, fixing LP #1741752 by ensuring LXD re-injects required snaps when needed.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#1865 as commit e99354492, making LXD re-inject snaps when necessary to fix LP: #1741752.
stealth/space-bunny-alpha — closed resolved Merged #1865 via commit e99354492, ensuring LXD reinjects required snaps and correctly handles revisioned and side-loaded snaps; fixes LP #1741752.
qwen/qwen3.6-35b-a3b — — Merged to fix LP: #1741752 by ensuring LXD containers always re-inject snaps. Changes refactor injection logic, reorganize files, and properly handle side-loaded snap assertions. Approved by reviewer and passed CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged to always re-inject snaps into existing LXD containers, fixing Launchpad bug 1741752. The update refactors inject_snap to use SHA384sum comparisons and handles file movements for side-loaded snaps.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1568 lxd: don't re-inject the same snaps snapcraft merged Merged PR #1568 as commit 1bd531772, preventing LXD from re-injecting identical snaps by comparing hashes instead of revision-based filenames; fixes LP #1716923.
85%
#2222 lxd: support new style snap injection snapcraft merged Merged in #2222 via commit 8acd203, adding new-style LXD snap handling, removing sudo-based injection, and consolidating duplicated tests.
78%
#1364 lxd: Inject snapcraft and core snaps into the container snapcraft merged Merged PR #1364 as 99f5598ac, injecting the host's Snapcraft and core snaps into LXD containers so builds no longer use a mismatched Xenial archive version.
76%
#1577 lxd: don't inject local snaps on a different arch snapcraft merged Merged in snapcraft#1577 via commit 5cef61310, preventing incompatible local snaps from being injected into cross-architecture LXD builds and using store snaps instead.
76%
#1912 lxd: unset SNAP to work-around LXD deb thinking it's a snap snapcraft closed The SNAP-unset workaround for LP #1746612 was rejected and PR #1912 was closed unmerged; no Snapcraft fix landed.
72%
#1788667 changes in snapd break lxd snap injection for cleanbuild snapcraft (launchpad) closed snapd's 0600 perms on injected snaps broke LXD cleanbuild injection. Fixed by merged PR snapcore/snapcraft#2222 (commit b2bd6b776), adding new-style LXD snap injection; bug closed.
72%
#1716923 Installing core snap in container often fails snapcraft (launchpad) closed Fixed by merged PR #1568 (commit 1bd531772), which stopped LXD container builds from re-injecting identical snaps.
72%
#2098 lxd: wait for on-going refreshes to finish snapcraft merged PR #2098 by kalikiana merged (commit 7666a74a7), adding a `snap watch` call before injecting core/snapcraft snaps into LXD containers so in-progress refreshes finish. Fixes #2037 and LP bug #1722049.
71%
#343 lxd should be a suggestion, not a direct dep snapcraft merged Merged in snapcraft PR #343 as 7147a43ba, changing LXD from a direct dependency to a suggestion and resolving LP #1550381.
71%