← Back to issue list

kernel plugin: remove dependency on magic

View original Github issue

Metadata

Project
snapcraft
Number
#1867
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Removed the magic library dependency from the kernel plugin. Merged after reviewer approval and CI validation. Verified by kyrofa and resolves Launchpad bug #1742504, reducing code by 42 lines across two files.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Removed the magic library dependency from the kernel plugin. Merged after reviewer approval and CI validation. Verified by kyrofa and resolves Launchpad bug #1742504, reducing code by 42 lines across two files.
qwen3.6-35b-a3b-mtp-q6 Merged changes removing the magic dependency from the kernel plugin. Fixed Launchpad bug #1742504 after successful testing and maintainer review.
qwen3.6-35b-a3b-mtp-q6 Merged to remove the magic library dependency from the kernel plugin, resolving Launchpad bug #1742504. Verified working by maintainer.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#837 kernel plugin: allow collecting the same mod deps snapcraft merged Merged kernel plugin fix eliminating duplicate module dependencies via set conversion. Approved by one reviewer. Modifies two files: +36/-1 lines.
70%