← Back to issue list

kernel plugin: remove dependency on magic

View original Github issue

Metadata

Project
snapcraft
Number
#1867
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1867 removed the kernel plugin's dependency on magic, addressing LP #1742504; it landed as commit a4e4d3e90.

Resolution: closed resolved

Reason: The approved change was merged as commit a4e4d3e90, eliminating the magic dependency from the kernel plugin. A reviewer confirmed the change worked.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1867 removed the kernel plugin's dependency on magic, addressing LP #1742504; it landed as commit a4e4d3e90.
stealth/space-bunny-alpha — closed resolved Merged #1867 as a4e4d3e90, removing the kernel plugin's dependency on magic and resolving LP #1742504.
stealth/space-bunny-alpha — closed resolved Merged snapcore/snapcraft#1867, removing the kernel plugin's dependency on magic to address LP #1742504. Landed as a4e4d3e90.
stealth/space-bunny-alpha — closed resolved Merged snapcore/snapcraft#1867 removes the kernel plugin’s dependency on magic, addressing LP #1742504. Landed as commit a4e4d3e90.
stealth/space-bunny-alpha — closed resolved Merged snapcraft#1867 as a4e4d3e90, removing the kernel plugin's Python magic dependency. The approved change cites Launchpad #1742504 and includes kyrofa's verification.
qwen/qwen3.6-35b-a3b — — Removed the magic library dependency from the kernel plugin. Merged after reviewer approval and CI validation. Verified by kyrofa and resolves Launchpad bug #1742504, reducing code by 42 lines across two files.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes removing the magic dependency from the kernel plugin. Fixed Launchpad bug #1742504 after successful testing and maintainer review.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.