← Back to issue list

adding option to decompress tar.lzma cleanly

View original Github issue

Metadata

Project
snapcraft
Number
#1872
Type
pull request
State
closed
Author
heesen3
Labels
—
Created
Updated
Closed

Current evaluation

PR #1872 was closed unmerged after a maintainer cited missing tests and advised the contributor to complete further Python exercises before resubmitting.

Resolution: closed stale

Reason: No code was merged. On 2018-01-15, maintainer @come-maiz noted that the PR added no tests and encouraged the contributor to improve their Python skills before trying again; no replacement PR was identified.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed stale PR #1872 was closed unmerged after a maintainer cited missing tests and advised the contributor to complete further Python exercises before resubmitting.
stealth/space-bunny-alpha — closed stale PR #1872 was closed unmerged after a maintainer cited missing tests and advised the contributor to gain more Python experience before resubmitting.
qwen/qwen3.6-35b-a3b — — The request was closed and rejected. The reviewer cited missing tests and advised the contributor to improve Python skills through other tasks before resubmitting.
qwen3.6-35b-a3b-mtp-q6 — — Rejected due to missing tests for the tar.lzma decompression feature. Reviewer advised improving Python skills first and offered mentoring before resubmission.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft (launchpad)#1567524 (confidence 98%)

    The author linked this Launchpad bug, “Support tar.lzma,” to the proposed change.

Related issues

Issue Project State Summary Similarity
#1859 adding option to decompress tar.lzma cleanly snapcraft closed Closed unmerged after maintainers rejected the GUI-dialog approach as outside Snapcraft's runtime model; the underlying tar.lzma bug remained tracked in Launchpad #1567524.
76%
#1567524 Support tar.lzma snapcraft (launchpad) open Open, maintainer-acknowledged enhancement for clean tar.lzma source extraction; an old reproducer emitted errors despite eventually producing files.
70%
#1871 support .tar.lzma cleanly in snapcraft snapcraft closed PR #1871 was closed unmerged on 13 Jan 2018 after a maintainer said the branch was not ready; it received no review or CI and did not add .tar.lzma support.
70%