← Back to issue list

Close not called on the qml plugin

View original Github issue

Metadata

Project
snapcraft
Number
#188
Type
pull request
State
merged
Author
renatgalimov
Labels
—
Created
Updated
Closed

Current evaluation

Merged in snapcraft#188 via merge commit 1045bd9a5, with squashed commit 731c7747e fixing the missing QML plugin close call.

Resolution: closed resolved

Reason: The pull request was merged as commit 1045bd9a5. Its squashed implementation commit, 731c7747e, added the missing close call to the QML plugin.

Evaluated by: mr-cal-bot

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in snapcraft#188 via merge commit 1045bd9a5, with squashed commit 731c7747e fixing the missing QML plugin close call.
stealth/space-bunny-alpha — closed resolved Merged snapcraft#188 in commit 1045bd9a5, fixing the missing QML plugin close call with squashed commit 731c7747e.
qwen/qwen3.6-35b-a3b — — Merged after the contributor signed the CLA and squashed commits. The change ensures the close method is properly called on the qml plugin. Approved by maintainers and requested for cherry-picking to the 1.x branch.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix ensuring Close is properly called on the qml plugin. The contributor signed the CLA, squashed commits, and received maintainer approvals. The change was requested for cherry-picking to the 1.x branch.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1531994 QML plugin doesn't close snappy-qt5.conf snapcraft (launchpad) closed Fixed the leaked snappy-qt5.conf handle in the QML plugin via snapcraft#188, commit 731c7747e, merged as 1045bd9a5.
80%
#205 Backport to 1.x: Close not called on the qml plugin snapcraft merged Merged the QML plugin close() fix into the 1.x branch via #205, backporting #188 (commit 1045bd9a5; original fix 731c7747e).
76%
#1551343 Remove qml plugin snapcraft (launchpad) closed Removed the assumption-dependent QML plugin in ubuntu-core/snapcraft PR #469, merged as commit 12b892588, because it failed in common environments such as X11.
73%