← Back to issue list

many: handle copying of symlink permissions gracefully

View original Github issue

Metadata

Project
snapcraft
Number
#1900
Type
pull request
State
closed
Author
kalikiana
Labels
—
Created
Updated
Closed

Current evaluation

PR replacing shutil.copytree with a custom version to suppress symlink permission 'not found' errors (LP #1744921) was closed unmerged after kyrofa questioned the rewrite's necessity; review stayed pending with no CI or follow-up.

Resolution: closed stale

Reason: The PR was never merged: the only comment was maintainer kyrofa's 2018-02-27 objection that rewriting copytree was overkill and the underlying problem untriaged. Review status remained pending, no CI checks ran, and no superseding commit or PR exists in the repo for the symlink permission copy error.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- Fixes: [LP: #1744921](https://bugs.launchpad.net/snapcraft/+bug/1744921) Manual test steps: > # Install Snapcraft snap from this branch > export SNAPCRAFT_CONTAINER_BUILDS=<remote> > cd snapcraft/tests/integration/snaps/symlinks/ > snapcraft My proposed fix is to replace `shutil.copytree` with our own version to achieve two things: - Don't swallow errors, which makes both handling and debugging them difficult - Suppress the "not found" error that may occur with copying of symlink permissions Note: Testing this is a bit involved because it only occurs when Snapcraft is run inside a container inside an sshfs mount. We don't currently have any integration tests for this setup.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed stale PR replacing shutil.copytree with a custom version to suppress symlink permission 'not found' errors (LP #1744921) was closed unmerged after kyrofa questioned the rewrite's necessity; review stayed pending with no CI or follow-up.
stealth/space-bunny-alpha — closed stale Unmerged after a maintainer questioned the copytree rewrite and requested clearer problem triage; review remained pending, with no CI, replacement, or later resolution recorded.
qwen/qwen3.6-35b-a3b — — Proposed custom copytree implementation to handle symlink permission errors on sshfs was closed without merging. Reviewers questioned the approach and noted insufficient bug triaging, resulting in rejection.
qwen3.6-35b-a3b-mtp-q6 — — Proposed replacing shutil.copytree to gracefully handle symlink permission copying errors. Maintainer feedback questioned the approach as overkill and noted unclear bug triaging. Rejected and closed without merging.

Update history

No update history recorded yet.

Related work

  • Related To: LP:#1744921 (confidence 40%)

    Launchpad bug referenced in the PR body as the bug being fixed; not a GitHub-tracked item

Related issues

No related issues found above the similarity threshold.