← Back to issue list

many: use in-snap unsquashfs and readelf if running from snap

View original Github issue

Metadata

Project
snapcraft
Number
#1902
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged after review approval and passing CI. The change updates Snapcraft to use in-snap unsquashfs and readelf when running from a snap, modifying 11 files with 133 additions and 20 deletions.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after review approval and passing CI. The change updates Snapcraft to use in-snap unsquashfs and readelf when running from a snap, modifying 11 files with 133 additions and 20 deletions.
qwen3.6-35b-a3b-mtp-q6 Merged by kyrofa, this pull request updates the code to use in-snap versions of unsquashfs and readelf when running from a snap. The change was accepted and integrated into the main branch without additional discussion.
qwen3.6-35b-a3b-mtp-q6 Merged changes to use in-snap unsquashfs and readelf when Snapcraft runs from a snap package. The pull request was integrated without additional discussion.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#6206 snapcraft fails to unsquashfs some snaps snapcraft closed Fixed by modifying the snap extraction utility to only extract required files, resolving unsquashfs failures on snaps containing character devices. The fix is included in Snapcraft 9.
73%
#544 fix(i/snap): don't reject non-snap squashfs files fetch-service merged Merged a fix to the snap inspector that ignores non-snap squashfs files instead of rejecting them. Approved by two reviewers, passed all CI checks, and applied with 16 additions and 4 deletions across two files.
71%
#3173 cli: use snap pack instead of mksquashfs snapcraft merged Merged. Replaced mksquashfs with snap pack, aligning with snapd standards and removing the --check-skeleton flag. Code refactored into snapcraft.cli. Windows support deferred to multipass. Approved and merged after passing CI.
70%