catkin plugin: extract Wstool into its own module
Metadata
Current evaluation
Merged after resolving conflicts. Extracts Wstool from the catkin plugin into a standalone module to support recursive rosinstall file parsing. Approved by two reviewers with passing CI checks.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Currently Wstool is a class within the Catkin plugin. However, in order to support recursively parsing rosinstall files (#1714), Wstool needs to undergo some changes. In order to ease that work, extract Wstool into its own module.
Note that I added some basic error handling here, but no other changes have been made.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after resolving conflicts. Extracts Wstool from the catkin plugin into a standalone module to support recursive rosinstall file parsing. Approved by two reviewers with passing CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after resolving conflicts. Extracts the Wstool class from the catkin plugin into a standalone module, reducing plugin size and preparing for recursive rosinstall file parsing. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after resolving conflicts. Extracts Wstool from the catkin plugin into a standalone module to enable recursive rosinstall file parsing. Adds basic error handling without altering existing functionality. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1934 catkin plugin: support recursive rosinstall files | snapcraft | merged | Merged. Introduces a recursive-rosinstall boolean option to the Catkin plugin, enabling automatic resolution of nested rosinstall files unsupported by wstool. Defaults to false. Resolves #1714 following successful review and CI checks. | |
| #2852 wstool: don't rely on host git | snapcraft | merged | Merged a fix ensuring wstool uses its bundled git instead of relying on host git. This enables rosinstall file merging without host git installed. Approved by one reviewer with passing CI checks. |