elf: better debug messages
Metadata
Current evaluation
Merged pull request polishing ELF debug messages for linker and library exclusion checks. Changes eliminate repetitive logging and reduce unnecessary calls. Approved by reviewers, passed CI, and successfully integrated.
Suggested action: —
No scores available.
Issue body
Some debug messages needed polishing, like the linker check.
Others, like the check for exclusions of libraries, needed
polish to not repeat itself over and over again when
running off of a non supported base. This comes with a
side effect of reducing the amount of calls necessary
for the check where the debug message is displayed.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged pull request polishing ELF debug messages for linker and library exclusion checks. Changes eliminate repetitive logging and reduce unnecessary calls. Approved by reviewers, passed CI, and successfully integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged improvements to ELF debug messages. Polished linker check output and eliminated redundant library exclusion warnings on unsupported bases, reducing unnecessary function calls. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged ELF debug message improvements. Polished linker check output, removed redundant library exclusion warnings on unsupported bases, and optimized call frequency. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3119 elf: fix string format for debug log | snapcraft | merged | Merged to fix the ELF debug log string format. Approved by one reviewer, passed CI, and applied a minimal two-line change to resolve the issue. | |
| #1989 elf: don't parse elf more than necessary | snapcraft | merged | Merged a single-line change optimizing ELF parsing to avoid unnecessary work, yielding a minor performance improvement. Approved by a maintainer and passed CI checks. | |
| #2746 elf: handle missing dependencies not found on system | snapcraft | merged | Merged updates to handle missing ELF dependencies when ldd fails to resolve them. The change prevents filtering unresolved libraries, refactors ldd parsing for reliability, and adds unit tests. Approved by one reviewer and passed CI checks. | |
| #2929 elf: fixes for corrupt shared objects | snapcraft | merged | Merged to master. Resolves corrupt shared object handling by catching elftools ConstructErrors and skipping corrupted ELF files during library crawling. Approved, passed CI, and achieved 100% diff coverage. | |
| #75 refactor: rewrite elf file support | debcraft | merged | Merged rewrite of ELF file support to better match deb building needs, replacing Snapcraft's implementation. Handles needed libraries; symbol support deferred. Approved by two reviewers, passed all CI checks, and resolves #72. | |
| #3840 elf: add handling and patching helpers | snapcraft | merged | Merged into main following reviewer approval and passing CI checks. Introduces ELF binary listing and dynamic linker location helpers, adding handling and patching utilities to the elf module while increasing test coverage. | |
| #2229 elf: extract build ID and presence of debug info | snapcraft | merged | Updates the ElfFile class to extract ELF build IDs and detect debug info presence. Merged after approval by two reviewers and passing CI checks. Simplifies section extraction logic to support debug symbol separation. | |
| #2663 elf: handle invalid elf files | snapcraft | merged | Merged changes to handle invalid ELF files by catching elftools exceptions and silently ignoring them. Includes a regression test, passed CI, and achieved 100% diff coverage. Resolves LP #1838098. | |
| #2000 elf: remove dead code | snapcraft | merged | Merged removal of dead code in the ELF module. The unused magic string was eliminated after the logic migrated to the ElfFile class. Approved by a reviewer and passed CI checks. |