elf: better debug messages
Metadata
Current evaluation
Merged #1950 in commit 7b8271737, polishing ELF linker and library-exclusion debug output while removing repeated checks and messages on unsupported bases.
Resolution: closed resolved
Reason: The approved pull request was merged as commit 7b8271737, improving debug messages and eliminating unnecessary ELF library checks.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Some debug messages needed polishing, like the linker check.
Others, like the check for exclusions of libraries, needed
polish to not repeat itself over and over again when
running off of a non supported base. This comes with a
side effect of reducing the amount of calls necessary
for the check where the debug message is displayed.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #1950 in commit 7b8271737, polishing ELF linker and library-exclusion debug output while removing repeated checks and messages on unsupported bases. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in commit 7b8271737, improving ELF linker and library-exclusion debug messages and avoiding repeated checks and output on unsupported bases. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #1950 in commit 7b8271737, improving ELF linker and library-exclusion debug messages, reducing repeated output, and avoiding unnecessary checks on unsupported bases. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged pull request polishing ELF debug messages for linker and library exclusion checks. Changes eliminate repetitive logging and reduce unnecessary calls. Approved by reviewers, passed CI, and successfully integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged improvements to ELF debug messages. Polished linker check output and eliminated redundant library exclusion warnings on unsupported bases, reducing unnecessary function calls. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3287 elf: reduce noise in the developer debug logs | snapcraft | closed | PR #3287's five-line ELF debug-log cleanup was not merged; it was closed as stale on 2020-09-28 with three unresolved review comments. | |
| #1989 elf: don't parse elf more than necessary | snapcraft | merged | Merged #1989 (commit 393ba2c63) to avoid parsing ELF files more than necessary, reducing redundant work for a small performance gain. | |
| #3119 elf: fix string format for debug log | snapcraft | merged | Merged PR #3119 in commit e9d758fac, fixing the string format used in the ELF debug log. |