elf: only consider regular files as possible ELF binaries

Metadata

Project: snapcraft
Number: #1976
Type: pull request
State: merged
Author: jhenstridge
Labels: —
Created: 2018-03-02 03:30 AM UTC
Updated: 2018-03-02 08:21 PM UTC
Closed: 2018-03-02 08:21 PM UTC

Current evaluation

Merged PR #1976 in commit ef3309f3c, limiting ELF detection to regular files and symlinks to them so device nodes no longer break core snap builds.

Resolution: closed resolved

Reason: PR #1976 was approved and merged as commit ef3309f3c, updating ElfFile.is_elf to exclude device nodes and fix LP #1752766.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- Only consider regular files (or symlinks to regular files) as possible ELF binaries in `ElfFile.is_elf`. At present, Snapcraft has trouble building the core snap due to the presence of device files. LP: #1752766

Evaluation history

Date	Model	Scores	Action	Summary
2026-10-03 05:28 AM UTC	stealth/space-bunny-alpha	—	closed resolved	Merged PR #1976 in commit ef3309f3c, limiting ELF detection to regular files and symlinks to them so device nodes no longer break core snap builds.
2026-09-25 02:57 AM UTC	stealth/space-bunny-alpha	—	closed resolved	Merged PR #1976 in commit ef3309f3c, restricting ELF detection to regular files and symlinks so device nodes no longer break core snap builds.
2026-07-22 02:58 PM UTC	qwen/qwen3.6-35b-a3b	—	—	Merged a fix restricting ELF binary detection to regular files, resolving Snapcraft core snap build failures caused by device files being misidentified. Approved by reviewers and passed CI checks.
2026-07-19 07:17 PM UTC	qwen3.6-35b-a3b-mtp-q6	—	—	Merged fix restricting ELF binary detection to regular files and symlinks. Resolves core snap build failures caused by device files being incorrectly identified as ELF binaries.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.