← Back to issue list

tests: remove the internal os_release dependency

View original Github issue

Metadata

Project
snapcraft
Number
#1981
Type
pull request
State
merged
Author
come-maiz
Labels
Created
Updated
Closed

Current evaluation

Merged after approval. Removes the internal os_release dependency from tests, closing issue #1952. Two files changed with 52 additions and 10 deletions.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- closes #1952

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approval. Removes the internal os_release dependency from tests, closing issue #1952. Two files changed with 52 additions and 10 deletions.
qwen3.6-35b-a3b-mtp-q6 Merged changes that remove the internal os_release dependency from the test suite, resolving issue #1952.
qwen3.6-35b-a3b-mtp-q6 Merged. Removes the internal os_release dependency from the test suite, resolving issue #1952. The change eliminates unnecessary system release file parsing to streamline test execution.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1971 tests: remove dependency of internal repo from integration suite snapcraft merged Merged. Removed the internal repository dependency from the integration test suite, closing issue #1973. Approved by one reviewer, the change modified four files with 66 additions and 10 deletions.
74%
#1653 internal: don't reuse variable in OsRelease snapcraft merged Merged an internal cleanup that stops reusing a variable in OsRelease. Approved by two reviewers with passing CI checks. The change modifies a single file with two additions and two deletions.
71%