← Back to issue list

many: optimize retrieval of the linker version

View original Github issue

Metadata

Project
snapcraft
Number
#2017
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged optimization that avoids retrieving the linker version from core when already known, streamlining compatibility checks. Approved by one reviewer, passed CI, and modified seven files.

Suggested action:

No scores available.

Issue body

When checking for compatibility when the host is not ideal for the base the base needs to be installed. In many cases the linker version for the base is known in advance so retrieving the linker from the core is not required. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged optimization that avoids retrieving the linker version from core when already known, streamlining compatibility checks. Approved by one reviewer, passed CI, and modified seven files.
qwen3.6-35b-a3b-mtp-q6 Merged optimization that bypasses core linker version retrieval during base compatibility checks when the version is pre-known, reducing unnecessary system calls.
qwen3.6-35b-a3b-mtp-q6 Merged optimization that skips core linker version retrieval when already known, improving compatibility checks. Successfully integrated by maintainer sergiusens.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3138 project: add core20 linker version snapcraft merged Approved and passed CI checks, the change adding core20 linker version support was merged into the main branch with a single two-line file modification.
73%