elf: set no-default-lib for all elf files if patching
Metadata
Current evaluation
Merged after a reviewer reported a git-ubuntu regression causing empty rpaths. The author could not reproduce it and proposed merging in two weeks to discuss the issue with another maintainer, which was agreed upon.
Suggested action: —
No scores available.
Issue body
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after a reviewer reported a git-ubuntu regression causing empty rpaths. The author could not reproduce it and proposed merging in two weeks to discuss the issue with another maintainer, which was agreed upon. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged despite reported empty rpath issues affecting git-ubuntu. The change sets no-default-lib for ELF files during patching. Maintainers agreed to merge temporarily to address the regression with nacc later. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after a two-week delay to address empty rpath issues affecting git-ubuntu. The change sets no-default-lib for patched ELF files, with plans to resolve the library finding logic conflict with another maintainer. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1988 elf: only set rpaths to libs of the same arch | snapcraft | merged | Merged after reviewer approval. Fixes LP #1752964 by restricting ELF rpath resolution to libraries matching the target architecture alongside soname, preventing incorrect selection when multiple architectures exist in the core snap. |