← Back to issue list

Add an option for setting npm flags option

View original Github issue

Metadata

Project
snapcraft
Number
#2038
Type
pull request
State
merged
Author
guilhem
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2038 added configurable npm flags to Snapcraft's Node.js plugin, enabling workarounds such as --no-optional; landed in commit 05b6cdb2f.

Resolution: closed resolved

Reason: PR #2038 was approved and merged as commit 05b6cdb2f, adding the requested npm-flags option to the Node.js plugin. This enabled the --no-optional workaround discussed for LP: #1742559.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This is useful when I faced this problem https://github.com/npm/npm/issues/18287 (sadly not only on windows) on this project: https://github.com/webpro/reveal-md I had to add `--no-optional` flag to work.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2038 added configurable npm flags to Snapcraft's Node.js plugin, enabling workarounds such as --no-optional; landed in commit 05b6cdb2f.
stealth/space-bunny-alpha — closed resolved Merged PR #2038 added configurable npm flags to the Node.js plugin, enabling workarounds such as --no-optional for LP: #1742559.
qwen/qwen3.6-35b-a3b — — Merged pull request adding npm flag configuration option, enabling workarounds like --no-optional. Reviewer updated unit tests after contributor declined. Resolves Launchpad bug #1742559.
qwen3.6-35b-a3b-mtp-q6 — — Added option to set npm and yarn flags. Maintainers completed unit tests and merged the changes, resolving Launchpad bug #1742559.

Update history

No update history recorded yet.

Related work

  • Related To: npm#18287 (confidence 95%)

    The upstream npm dependency problem that motivated configurable flags such as --no-optional.

Related issues

No related issues found above the similarity threshold.