← Back to issue list

many: add override-stage scriptlet

View original Github issue

Metadata

Project
snapcraft
Number
#2049
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged in PR #2049 (commit c5ca9ef8), adding override-stage and snapcraftctl stage so overridden parts can invoke the default stage action, completing #1673.

Resolution: closed resolved

Reason: PR #2049 was merged as commit c5ca9ef8, implementing the stage override and default-stage subcommand requested in snapcraft#1673.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- Currently Snapcraft supports override scriptlets for both the pull and build steps. This PR resolves #1673 by adding one for the stage step called `override-stage` which, if specified, overrides the part's stage step. It also adds a `stage` subcommand to `snapcraftctl` to ensure developers can still complete the default stage action.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in PR #2049 (commit c5ca9ef8), adding override-stage and snapcraftctl stage so overridden parts can invoke the default stage action, completing #1673.
stealth/space-bunny-alpha — closed resolved Merged PR #2049 (commit c5ca9ef8), adding override-stage and snapcraftctl stage to complete issue #1673.
qwen/qwen3.6-35b-a3b — — Merged override-stage scriptlet, resolving issue #1673. Introduces stage step override capability and a snapcraftctl stage subcommand for default behavior. Author fixed FakeLXD test failures prior to merge.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Adds the override-stage scriptlet and snapcraftctl stage subcommand, resolving #1673. Integrated after the author fixed FakeLXD mocking test failures.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#1673 (confidence 100%)

    Feature request resolved by the merged override-stage implementation in PR #2049.

Related issues

Issue Project State Summary Similarity
#1673 Add pre-stage/stage/post-stage snapcraft closed Closed without implementation or a recorded reason; later PRs #2049 and #2052 added override-stage and override-prime lifecycle scriptlets.
74%
#2045 many: add override-pull scriptlet snapcraft merged Merged as commit 56c16cbc5: added override-pull and snapcraftctl pull; Local sources now merge into the existing directory to preserve pre-pull changes.
73%
#2052 many: add override-prime scriptlet snapcraft merged Merged PR #2052 via commit 15119aa7e, adding the override-prime scriptlet and a snapcraftctl prime command for running the default prime action.
73%
#2002 many: add snapcraftctl command for scriptlets snapcraft merged Merged PR #2002 (commit bbca282fa) added the snapcraftctl CLI for scriptlets to talk to the parent Snapcraft process, including `snapcraftctl build` and the override-build scriptlet. Resolved #1675 and LP #1751749.
70%