← Back to issue list

many: update the yaml loading logic

View original Github issue

Metadata

Project
snapcraft
Number
#2065
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Updated YAML loading to use safe loading where possible, fixing #2033; merged via #2065 in commit 49f07a1ba.

Resolution: closed resolved

Reason: PR #2065 was approved and merged, resolving #2033. The changes were recorded in commit 49f07a1ba.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Use safe loading where possible. Fixes #2033 LP: #1752344 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Updated YAML loading to use safe loading where possible, fixing #2033; merged via #2065 in commit 49f07a1ba.
stealth/space-bunny-alpha — closed resolved Merged PR #2065 in commit 49f07a1ba, updating YAML loading to use safe loading where possible and fixing #2033.
qwen/qwen3.6-35b-a3b — — Merged after approval and CI checks, updating YAML loading to use safe loading where possible and resolving issue #2033.
qwen3.6-35b-a3b-mtp-q6 — — Merged after discussion on selective YAML updates. Implements safe loading to resolve #2033 and LP: #1752344.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: snapcraft#2033 (confidence 100%)

    PR #2065 explicitly states that it fixes #2033.

Related issues

Issue Project State Summary Similarity
#2218 yaml: replace yaml.safe_load() with CSafeLoader snapcraft merged Merged #2218 in commit 2e6ed7fd1, adopting CSafeLoader for faster, C-backed YAML parsing and fixing LP#1787373.
76%
#2033 LP: #1752344 snapcraft closed Fixed by the YAML-loading update merged in PR #2065 (commit 49f07a1ba).
75%