← Back to issue list

errors: skip the sentry test if raven is no installed

View original Github issue

Metadata

Project
snapcraft
Number
#2075
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

PR #2075 merged as 6a9f23d49, making the Sentry traceback test skip when optional raven is unavailable and run normally when installed.

Resolution: closed resolved

Reason: Snapcraft merged PR #2075 in commit 6a9f23d49, adding an availability guard so environments without the optional raven dependency skip rather than fail the Sentry test.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- ``` (snapcraft) ubuntu@snapcraft-xenial-dev:~/source/snapcraft$ python3 -m unittest -v run tests.unit.cli.test_errors.ErrorsTestCase.test_handler_traceback_send_traceback_to_sentry run (unittest.loader._FailedTest) ... ok test_handler_traceback_send_traceback_to_sentry (tests.unit.cli.test_errors.ErrorsTestCase) tests.unit.cli.test_errors.ErrorsTestCase.test_handler_traceback_send_traceback_to_sentry ... skipped 'raven needs to be installed for this test.' ---------------------------------------------------------------------- Ran 2 tests in 0.061s OK (skipped=1) (snapcraft) ubuntu@snapcraft-xenial-dev:~/source/snapcraft$ pip install raven Collecting raven Downloading raven-6.6.0-py2.py3-none-any.whl (282kB) 100% |████████████████████████████████| 286kB 405kB/s Installing collected packages: raven Successfully installed raven-6.6.0 (snapcraft) ubuntu@snapcraft-xenial-dev:~/source/snapcraft$ python3 -m unittest -v run tests.unit.cli.test_errors.ErrorsTestCase.test_handler_traceback_send_traceback_to_sentry run (unittest.loader._FailedTest) ... ok test_handler_traceback_send_traceback_to_sentry (tests.unit.cli.test_errors.ErrorsTestCase) tests.unit.cli.test_errors.ErrorsTestCase.test_handler_traceback_send_traceback_to_sentry ... ok ---------------------------------------------------------------------- Ran 2 tests in 0.078s OK ```

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #2075 merged as 6a9f23d49, making the Sentry traceback test skip when optional raven is unavailable and run normally when installed.
stealth/space-bunny-alpha — closed resolved Merged as commit 6a9f23d49: the Sentry traceback test now skips when the optional raven package is absent.
stealth/space-bunny-alpha — closed resolved PR #2075 merged as commit 6a9f23d49, making the Sentry traceback unit test skip when the optional raven dependency is unavailable.
stealth/space-bunny-alpha — closed resolved PR #2075 merged as commit 6a9f23d49, making the Sentry traceback unit test skip when the optional raven dependency is unavailable.
qwen/qwen3.6-35b-a3b — — Merged a fix that conditionally skips the Sentry test when the raven dependency is missing. Approved by reviewers, passed CI, and updated one file to prevent test failures in environments without raven.
qwen3.6-35b-a3b-mtp-q6 — — Merged to skip the Sentry traceback test when the raven package is absent, avoiding failures in environments without the dependency. A separate isolated error was fixed in PR #2077.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#2077 (confidence 98%)

    The author identified #2077 as the fix for an isolated error associated with this PR.

Related issues

No related issues found above the similarity threshold.