delta: properly search for in-snap xdelta3
Metadata
Current evaluation
Merged PR #2127 (commit 146235160), replacing shutil.which with file_utils.get_tool_path so Snapcraft locates bundled xdelta3 when run as a snap; fixes LP #1769978.
Resolution: closed resolved
Reason: PR #2127 was merged as commit 146235160 after approval. The change fixes bundled xdelta3 discovery in the Snapcraft snap and addresses Launchpad bug #1769978.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Replace the current implementation of using shutil.which with
snapcraft's `file_utils.get_tool_path` to properly find xdelta3 when
run from the snapcraft snap.
LP: #1769978
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2127 (commit 146235160), replacing shutil.which with file_utils.get_tool_path so Snapcraft locates bundled xdelta3 when run as a snap; fixes LP #1769978. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #2127: replaced shutil.which with file_utils.get_tool_path so Snapcraft correctly locates its bundled xdelta3; addresses Launchpad #1769978. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix replacing shutil.which with file_utils.get_tool_path to correctly locate the in-snap xdelta3 binary. Approved, passed CI, and resolves Launchpad bug #1769978. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes replacing shutil.which with file_utils.get_tool_path to correctly locate xdelta3 within the snapcraft snap environment. Resolves LP: #1769978. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft (launchpad)#1769978
(confidence 100%)
Launchpad bug explicitly linked in the PR body and resolved by this merged change.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1769978 xdelta3 not generated using the snapcraft snap | snapcraft (launchpad) | closed | Fixed xdelta3 lookup in snapcraft snaps via snapcore/snapcraft#2127, merged as commit 146235160. | |
| #934 deltas: migrate from xdelta to xdelta3. | snapcraft | merged | Merged canonical/snapcraft#934, replacing xdelta with xdelta3 for delta generation; landed as commit f4abf6f4b. | |
| #1645456 Migrate xdelta to xdelta3 | snapcraft (launchpad) | closed | Snapcraft replaced xdelta with xdelta3 for delta generation via merged PR snapcraft#934 (commit f4abf6f4b), referenced by sergiusens when closing the bug. | |
| #1642822 Generate the delta file in snapcraft by introducing the new deltas package | snapcraft (launchpad) | closed | XDelta-based delta generation landed as the new snapcraft 'deltas' package, merged in canonical/snapcraft#918 (commit a129cdfee), with follow-ups adding delta uploads to push (#940) and xdelta3 migration (#934). |