← Back to issue list

errors: generic exception for common.run[_output]

View original Github issue

Metadata

Project
snapcraft
Number
#2132
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged in #2132 via commit 4936eff8c: common.run and common.run_output now catch subprocess.check_call/check_output failures and display consumable error messages.

Resolution: closed resolved

Reason: Pull request #2132 was merged into the project history as commit 4936eff8c, implementing generic handling for subprocess call/output failures with user-consumable messages.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Catch exceptions for subprocess.check_call and subprocess.check_output in snapcraft.internal.common and display a consumable message. Fixes SNAPCRAFT-11 Fixes SNAPCRAFT-G Fixes SNAPCRAFT-P Fixes SNAPCRAFT-5 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in #2132 via commit 4936eff8c: common.run and common.run_output now catch subprocess.check_call/check_output failures and display consumable error messages.
stealth/space-bunny-alpha — closed resolved Merged in snapcore/snapcraft#2132 (4936eff8c): common.run now surfaces consumable messages for subprocess.check_call/check_output failures.
qwen/qwen3.6-35b-a3b — — Merged. Adds generic exception handling for common.run and common.run_output to catch subprocess errors and display user-friendly messages. Resolves SNAPCRAFT-11, G, P, and 5.
qwen3.6-35b-a3b-mtp-q6 — — Merged: adds a generic exception for common.run and common.run_output to catch subprocess errors and display user-friendly messages. Resolves SNAPCRAFT-11, SNAPCRAFT-G, SNAPCRAFT-P, and SNAPCRAFT-5.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.