jhbuild plugin: allow running as 'root'
Metadata
Current evaluation
Merged PR #2141 as a017389fd, adding JHBUILD_RUN_AS_ROOT and removing the jhbuild plugin's previous root workaround.
Resolution: closed resolved
Reason: PR #2141 was approved and merged into master as commit a017389fd. It enabled root execution through JHBUILD_RUN_AS_ROOT and removed the obsolete workaround.
Evaluated by: mr-cal-bot
No scores available.
Issue body
JHBuild has recently acquired the ability to run under the root account with an environment variable to acknowledge the operation.
If applied, this commit will:
* Add JHBUILD_RUN_AS_ROOT environment variable to jhbuild plugin
* Remove previous attempt to work around snapcraft running under root from jhbuild plugin
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh unit`?
- `FAILED (failures=3, errors=5)`
- failures and errors are in unrelated parts of snapcraft:
- tests.unit.sources.test_bazaar.BazaarDetailsTestCase.test_bzr_details_commit
- tests.unit.sources.test_bazaar.BazaarDetailsTestCase.test_bzr_details_tag
- tests.unit.sources.test_mercurial.MercurialDetailsTestCase.test_hg_details_branch
- tests.unit.sources.test_mercurial.MercurialDetailsTestCase.test_hg_details_commit
- tests.unit.sources.test_mercurial.MercurialDetailsTestCase.test_hg_details_tag
- tests.unit.test_elf.TestPatcher.test_tools_from_snap_used_if_using_snap
- tests.unit.test_elf.TestPatcherErrors.test_patch_uses_snapped_strip
- tests.unit.test_lifecycle.CoreSetupTestCase.test_core_setup_if_docker_env
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2141 as a017389fd, adding JHBUILD_RUN_AS_ROOT and removing the jhbuild plugin's previous root workaround. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2141 (commit a017389fd) setting JHBUILD_RUN_AS_ROOT in the jhbuild plugin and dropping the prior root workaround (-80/+7 lines); approved by jhenstridge. The jhbuild plugin was later removed in #2371. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2141 (commit a017389fd): enabled root execution in the jhbuild plugin via JHBUILD_RUN_AS_ROOT and removed the previous workaround. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Adds JHBUILD_RUN_AS_ROOT environment variable to the jhbuild plugin to support root execution, replacing a previous workaround. Approved by reviewers and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after positive reviews. Adds the JHBUILD_RUN_AS_ROOT environment variable to the jhbuild plugin and removes a previous root workaround. Code coverage increased by 0.27%. |
Update history
No update history recorded yet.
Related issues
No related issues found above the similarity threshold.