many: automatically detect dependency changes
Metadata
Current evaluation
Closed unmerged after the author said it needed tweaks; re-proposed and merged as #2165 (commit 13881c35f), which auto-detects part dependency changes instead of lifecycle notifications, fixing LP #1778081.
Resolution: closed superseded
Reason: kyrofa commented "This needs another tweak. I'll re-propose" and the work landed in merged PR canonical/snapcraft#2165 (commit 13881c35f), which also fixes LP #1778081. PR #2161 itself was never merged.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh unit`?
-----
Currently the only way parts know they're dirty from dependency changes is if the lifecycle tells them so. This is a very error-prone approach, since if the lifecycle forgets to tell the part, then it doesn't know it needs to be cleaned. Dependency changes should be automatically detected instead of being noted in code, which also simplifies the upcoming feature of detecting source changes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged after the author said it needed tweaks; re-proposed and merged as #2165 (commit 13881c35f), which auto-detects part dependency changes instead of lifecycle notifications, fixing LP #1778081. | |
| stealth/space-bunny-alpha | — | closed resolved | Automatic dependency-change detection was merged as canonical/snapcraft#2165 (commit 13881c35f), replacing error-prone lifecycle notifications and fixing LP #1778081. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged automatic dependency-change detection in PR #2165, replacing lifecycle-notified dirty state and addressing LP #1778081. | |
| qwen/qwen3.6-35b-a3b | — | — | Abandoned without merging. The author indicated the implementation required further adjustments and planned to re-propose the automatic dependency detection logic in a subsequent pull request. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without merging. The author noted the implementation requires additional tweaks and will be re-proposed. Automatic dependency detection was not integrated. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/snapcraft#2165
(confidence 97%)
Same title and author, re-proposed after further tweaks; merged as commit 13881c35f.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2165 many: automatically detect dependency changes | snapcraft | merged | Merged PR #2165 as commit 13881c35f, adding automatic dirty-state detection for changed part dependencies and fixing LP #1778081. |