many: detect local source changes
Metadata
Current evaluation
Merged #2167, adding timestamp-based detection of local source changes so pull and subsequent steps refresh when local sources are newer; resolves LP #1583718.
Resolution: closed resolved
Reason: PR #2167 was merged as commit 39c4c39f1. It compares local source timestamps with the pull-state timestamp and updates the pull and all subsequent steps.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
The snapcraft CLI doesn't notice changes to local sources once the parts have been pulled: one must clean and re-pull in order to take them into account. This PR resolves [LP: #1583718](https://bugs.launchpad.net/snapcraft/+bug/1583718) by comparing local source timestamps to the pull state timestamp, and updating the pull (and all subsequent) steps as necessary.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #2167, adding timestamp-based detection of local source changes so pull and subsequent steps refresh when local sources are newer; resolves LP #1583718. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2167, fixing LP: #1583718 by detecting local source timestamp changes and automatically re-pulling sources before subsequent steps. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Resolves LP: #1583718 by comparing local source timestamps to pull state. Snapcraft now automatically triggers re-pulling and subsequent steps on local changes, removing manual cleaning. Approved and merged after test fixes. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after test fixes and review approval. Resolves LP #1583718 by comparing local source timestamps to pull state, automatically updating affected build steps when local files change. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1599 fix(sources): detect local file source changes | craft-parts | open | Adds mtime-based change detection for local file sources in FileSourceHandler (file:// counted as local), exposing outdated files and re-pulling on update. Fixes #1364. Approved by 2 reviewers; 1 open comment, OSV-scanner failing, slow test jobs still pending. | |
| #377 Correct local source pulling | snapcraft | merged | Merged PR #377 corrected symlink-aware local source checks, preventing cleanup failures and allowing local sources to be pulled twice without an "is a symlink" error. |